← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1989269] Re: Wrong assertion method in a unit test

 

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/856926
Committed: https://opendev.org/openstack/neutron/commit/653949808d2d5078102e2f6e2a70643071006b5b
Submitter: "Zuul (22348)"
Branch:    master

commit 653949808d2d5078102e2f6e2a70643071006b5b
Author: Takashi Natsume <takanattie@xxxxxxxxx>
Date:   Sun Sep 11 15:19:51 2022 +0900

    Fix a wrong assertion method
    
    Replace 'has_calls' with 'assert_has_calls'.
    
    Change-Id: Iff796608ac981aea2d093ab0e99e2de0c2cbb9b1
    Closes-Bug: 1989269
    Signed-off-by: Takashi Natsume <takanattie@xxxxxxxxx>


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1989269

Title:
  Wrong assertion method in a unit test

Status in neutron:
  Fix Released

Bug description:
  There is a wrong assertion method in the master.

  https://opendev.org/openstack/neutron/src/commit/ead685b9381bccb536a943409dc8ded57b65c70f/neutron/tests/unit/agent/l3/test_ha_router.py#L154

          mock_pm.disable.has_calls(calls)

  'has_calls' should be 'assert_has_calls'.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1989269/+subscriptions



References