← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1989254] Re: Neutron-dynamic-routing: misuse of assertTrue

 

Reviewed:  https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/856900
Committed: https://opendev.org/openstack/neutron-dynamic-routing/commit/1c15cd1bc594201dc5cc1dc3593ee7264c8759e2
Submitter: "Zuul (22348)"
Branch:    master

commit 1c15cd1bc594201dc5cc1dc3593ee7264c8759e2
Author: Takashi Natsume <takanattie@xxxxxxxxx>
Date:   Sat Sep 10 22:12:50 2022 +0900

    Fix misuse of assertTrue
    
    Replace assertTrue with assertEqual.
    
    Change-Id: I0f0b6e5a7a4b7799ecda2fcc5b5179c0f97fd44f
    Closes-Bug: 1989254
    Signed-off-by: Takashi Natsume <takanattie@xxxxxxxxx>


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1989254

Title:
  Neutron-dynamic-routing: misuse of assertTrue

Status in neutron:
  Fix Released

Bug description:
  There is a misuse of assertTrue in the neutron-dynamic-routing master
  (commit ddac34b3845a261d7c12cc37bf053948f6a3cfb9).

  neutron_dynamic_routing/tests/unit/db/test_bgp_dragentscheduler_db.py:83-84

              self.assertTrue(bgp_speaker_id,
                              res['bgp_speakers'][0]['id'])

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1989254/+subscriptions



References