yahoo-eng-team team mailing list archive

[OpenStack Infra <1976445@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/horizon/+/851258
Committed: https://opendev.org/openstack/horizon/commit/dd7faaa0231972b09d264b0ccc09e51f26a5fb12
Submitter: "Zuul (22348)"
Branch:    master

commit dd7faaa0231972b09d264b0ccc09e51f26a5fb12
Author: Tatiana Ovchinnikova <t.v.ovtchinnikova@xxxxxxxxx>
Date:   Wed Jul 27 15:20:23 2022 -0500

    Fix "Set admin password" checkbox visibility
    
    The checkbox should only be visible when 'can_set_password' is True.
    
    Closes-Bug: #1976445
    
    Change-Id: I887c4fcbccc6af77203d2b2bdb4f016fd9725f6c


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1976445

Title:
  Checkbox "Set admin password"  always is visible

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Hello,

  Options in local_settings not working correctly.

  OPENSTACK_HYPERVISOR_FEATURES{
  'can_set_password': False,
  }

  When we create instance we always see field "Set admin password" in
  Key Pair menu.

  If file

  https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-
  instance/keypair/keypair.html#L29

  replace

  <settings-service required-
  settings='["OPENSTACK_HYPERVISOR_FEATURES.can_set_password"]'>

  to

  <settings-service hz-if-
  settings='["OPENSTACK_HYPERVISOR_FEATURES.can_set_password"]'>

  fixit it.

  Testing OS Releases:
  Wallaby,Xena,Yoga

  Centos8-Stream

  Thank you,
  Den Nu

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1976445/+subscriptions