← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1991398] Re: Update port with given IPv6 address on SLAAC/stateless_dhpc subnets fails always when IP address is given

 

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/860054
Committed: https://opendev.org/openstack/neutron/commit/d7b44f7218ff665045adb923b1aa92c35b371af9
Submitter: "Zuul (22348)"
Branch:    master

commit d7b44f7218ff665045adb923b1aa92c35b371af9
Author: Slawek Kaplonski <skaplons@xxxxxxxxxx>
Date:   Sat Oct 1 22:06:11 2022 +0200

    Allow to pass EUI64 IP address as fixed ip for the port
    
    When port with IP address from the auto allocation subnet (SLAAC or
    dhcp_stateless) is created or updated and fixed IP address is specified,
    Neutron will fail as in case of such subnets IP address is assigned
    automatically based on the subnet's prefix and port's MAC address.
    But in case when given IP address is actually correct EUI64 generated IP
    address (the same as Neutron would generate for that port) there is no
    need to raise an exception and fail request.
    
    Additionally this patch fixes imports sections in the
    ipam_pluggable_backend module.
    
    Closes-bug: #1991398
    Change-Id: Iaee5608c9581228a83f7ad75dbf2cc31dafaa9ea


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1991398

Title:
  Update port with given IPv6 address on SLAAC/stateless_dhpc subnets
  fails always when IP address is given

Status in neutron:
  Fix Released

Bug description:
  There is simple test in the pluggable_ipam_module https://github.com/openstack/neutron/blob/1f1e45da6af4879725fb2d766f1989c8a10af474/neutron/db/ipam_pluggable_backend.py#L306 which will check if there is given fixed IPv6 address for port and will raise exception AllocationOnAutoAddressSubnet in such case if subnet is SLAAC or DHCP_stateless as in such cases IP addresses for ports are generated automatically based on the port's MAC address and subnet's prefix.
  That is generally correct but it will also fail if given IP address is actually correct (the same one as would be generated one). In such specific case this exception shouldn't be raised as nothing wrong would happen.

  For some reason this is causing some tobiko test failure sometimes
  during the cleanup phase when heat is trying to delete first IPv4 and
  then IPv6 subnet.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1991398/+subscriptions



References