yahoo-eng-team team mailing list archive

[Rodolfo Alonso <1552749@xxxxxxxxxxxxxxxxxx>]

Bug closed due to lack of activity, please feel free to reopen if
needed.

** Changed in: neutron
       Status: New => Won't Fix

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1552749

Title:
  Many BaseOVS functions unused

Status in neutron:
  Won't Fix

Bug description:
  When running vulture (https://pypi.python.org/pypi/vulture), I found many unused functions here:
  neutron/agent/common/ovs_lib.BaseOVS:

  neutron/agent/common/ovs_lib.py:118: Unused function 'add_bridge'
  neutron/agent/common/ovs_lib.py:131: Unused function 'bridge_exists'
  neutron/agent/common/ovs_lib.py:152: Unused function 'clear_db_attribute'
  neutron/agent/common/ovs_lib.py:209: Unused function 'set_standalone_mode'
  neutron/agent/common/ovs_lib.py:278: Unused function 'count_flows'
  neutron/agent/common/ovs_lib.py:373: Unused function 'get_iface_name_list'
  neutron/agent/common/ovs_lib.py:544: Unused function 'get_local_port_mac'
  neutron/agent/common/ovs_lib.py:553: Unused function 'set_controllers_connection_mode'
  neutron/agent/common/ovs_lib.py:581: Unused function 'get_egress_bw_limit_for_port'

  I didn't go through them all, but add_bridge and bridge_exists indeed
  don't seem used outside of tests.

  I ran vulture by going to Neutron base source dir, then running:
  vulture neutron --exclude=tests

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1552749/+subscriptions