yahoo-eng-team team mailing list archive

[Rodolfo Alonso <1979661@xxxxxxxxxxxxxxxxxx>]

** Changed in: neutron
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1979661

Title:
  [stable/train] member_batch_update  breaks contract with octavia-api
  interface

Status in neutron:
  Fix Released

Bug description:
  The prototype of the member_batch_update function in Octavia provider API in Train (16.x) [1]
  is member_batch_update(self, members). A change [2] was later done in Ussuri, to move to member_batch_update(self, pool_id, members) but it was not backported to train to keep backwards compatibility.

  So looks like the change on ovn-octavia-provider [3] was backported by
  error to stable/train and now the  call from octavia to the provider
  is triggering:

  2022-06-22 14:05:54.634 14 ERROR octavia.api.drivers.utils [req-8ad8a6ce-59cc-4531-94fa-d7918406d19f - 25b1efe043b54816ab6bd8e2b6b0d9c8 - default default] Provider 'ovn' raised an unknown error: member_batch_update() missing 1 required positional argument: 'members': TypeError: member_batch_update() missing 1 required positional argument: 'members'
  2022-06-22 14:05:54.634 14 ERROR octavia.api.drivers.utils Traceback (most recent call last):
  2022-06-22 14:05:54.634 14 ERROR octavia.api.drivers.utils   File "/usr/lib/python3.6/site-packages/octavia/api/drivers/utils.py", line 55, in call_provider
  2022-06-22 14:05:54.634 14 ERROR octavia.api.drivers.utils     return driver_method(*args, **kwargs)
  2022-06-22 14:05:54.634 14 ERROR octavia.api.drivers.utils TypeError: member_batch_update() missing 1 required positional argument: 'members'

  [1] https://opendev.org/openstack/octavia/src/branch/stable/train/octavia/api/drivers/amphora_driver/v2/driver.py#L217
  [2] https://review.opendev.org/c/openstack/octavia/+/688548/
  [3] https://review.opendev.org/c/openstack/networking-ovn/+/746134

  This is an issue just only over stable/train branch.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1979661/+subscriptions