yahoo-eng-team team mailing list archive

[OpenStack Infra <1997025@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/837780
Committed: https://opendev.org/openstack/neutron/commit/33de608f04dcc8117eeba63876598dc2ae93013a
Submitter: "Zuul (22348)"
Branch:    master

commit 33de608f04dcc8117eeba63876598dc2ae93013a
Author: Miguel Lavalle <mlavalle@xxxxxxxxxx>
Date:   Wed Apr 13 18:00:12 2022 -0500

    Avoid race condition when deleting trunk bridges
    
    Prior to this change, trunk bridges are created by os-vif but deleted
    by Neutron when the last vif is removed from it. This creates race
    conditions in some use cases, like DPDK with vhostuserclient mode, when
    VMs are rebooted. To avoid these races, Neutron will not delete trunk
    bridges anymore. Their creation and deletion will be os-vif's
    responsiblity. Since [1], Nova uses the os-vif version that contains
    this functionality.
    
    This patch also changes the trunk status change event. During a live
    migration, when the trunk parent port has been bound to the destination
    host (that means there is only one port binding associated) and the
    status has changed to ACTIVE, the method triggers the subport binding
    to the new host too. This is because there could be a race condition
    between the subport binding, triggered by the OVS agent, and the parent
    port binding, triggered by Nova. If when the OVS agent tries to bind the
    subports, the parent port is still bound to the source host, the subport
    binding remains in the source host too, instead of changing to the
    destination.
    
    This patch also reverts [2] and [3]. As commented in the previous
    paragraph, this patch fixes the issue reported in LP#1997025. The trunk
    port live migration with ML2/OVS must be fixed with this patch.
    
    [1]https://review.opendev.org/c/openstack/nova/+/865031
    [2]https://review.opendev.org/c/openstack/neutron/+/865295
    [3]https://review.opendev.org/c/openstack/neutron/+/865424
    
    Closes-Bug: #1869244
    Closes-Bug: #1997025
    
    Change-Id: I4e16357f3ff214fcf41e418982806c24088a2665


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1997025

Title:
  [CI] "test_live_migration_with_trunk" failing

Status in neutron:
  Fix Released

Bug description:
  Several occurrences during the last day:
  * https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_578/864215/2/check/neutron-ovs-tempest-multinode-full/5780784/testr_results.html
  * https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_4a0/864051/6/check/neutron-ovs-tempest-multinode-full/4a0fc4f/testr_results.html
  * https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_d4e/841838/69/check/neutron-ovs-tempest-multinode-full/d4e2c13/testr_results.html

  Zuul build list:
  https://zuul.opendev.org/t/openstack/builds?job_name=neutron-ovs-
  tempest-multinode-full&skip=0

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1997025/+subscriptions