yahoo-eng-team team mailing list archive

[OpenStack Infra <1973731@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/866409
Committed: https://opendev.org/openstack/neutron/commit/88b7db0e0c4d633748f454f4977c13c253012769
Submitter: "Zuul (22348)"
Branch:    master

commit 88b7db0e0c4d633748f454f4977c13c253012769
Author: Brian Haley <haleyb.dev@xxxxxxxxx>
Date:   Thu Dec 1 17:53:42 2022 -0500

    Mock ls_get in OVN metadata delete network unit test
    
    "TypeError: 'Mock' object is not iterable" could possibly
    be triggered by test_metadata_port_on_network_delete()
    since there is a missing mock of the return value for ls_get.
    
    Although I did not see the error described in the bug, I did
    verify ls_get was returning an incorrect value by printing
    it in the code, which after this patch was a fake row.
    
    Change-Id: Ib1f204c98eee96321c7befebf94012dc2c80b1e8
    Closes-bug: #1973731


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1973731

Title:
  [UT] Error output in "test_metadata_port_on_network_delete"

Status in neutron:
  Fix Released

Bug description:
  The unit test is not providing a return value to a mocked OVN DB
  method, "nb_idl.ls_get". This is the error output:
  https://paste.opendev.org/show/bs2WhKDEbdZQ6gid4s9E/

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1973731/+subscriptions