← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1856319] Re: [SRIOV] Agent is reporting "resources_synced=True" when restarted and placement is down

 

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/870956
Committed: https://opendev.org/openstack/neutron/commit/0ae432e71712be671ec93dded3245513b6810cd0
Submitter: "Zuul (22348)"
Branch:    master

commit 0ae432e71712be671ec93dded3245513b6810cd0
Author: elajkat <lajos.katona@xxxxxxxx>
Date:   Wed Jan 18 14:30:44 2023 +0100

    Fullstack: Wait placement process fixtrue to really stop
    
    It seems that in test test_configurations_are_synced_towards_placement
    when the fake placement process is stopped it can take longer and
    the test restarts the agent before it is really dead.
    In this case neutron-server can report the status and the agent's
    'resources_synced' field is True when the tests checks it.
    
    A simple workaround for this can be to check if the AsyncProcess
    class' _is_running property is False.
    
    Closes-Bug: #1856319
    Change-Id: Ia4c25110ee5a7b7539407d3531f559555fec50cc


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1856319

Title:
  [SRIOV] Agent is reporting "resources_synced=True" when restarted and
  placement is down

Status in neutron:
  Fix Released

Bug description:
  In fullstack test "test_configurations_are_synced_towards_placement",
  the Placement process is stopped, a new network is added and the L2
  agent is restarted (SRIOV in this case).

  
  The agent should sync the resources using the placement API, but because the Placement process is down, the server should report "resources_synced=False" until the placement report is received.

  
  In [1] can be seen that the first reply from the server, informing about the agent with the new configuration (new network), the flag is True ("resources_synced": true):
  2019-12-13 09:59:09.251 5513 DEBUG neutronclient.client [-] RESP: 200 {'Content-Type': 'application/json', 'Content-Length': '860', 'X-Openstack-Request-Id': 'req-363fc0e2-c3ae-4995-853b-cfbba9f2beb2', 'Date': 'Fri, 13 Dec 2019 09:59:09 GMT', 'Connection': 'keep-alive'} {"agents": [{"id": "158dea82-07e4-47d8-a65a-849e6de5e981", "agent_type": "NIC Switch agent", "binary": "neutron-sriov-nic-agent", "topic": "N/A", "host": "host-a677ed52", "admin_state_up": true, "created_at": "2019-12-13 09:58:39", "started_at": "2019-12-13 09:58:58", "heartbeat_timestamp": "2019-12-13 09:58:58", "description": null, "resources_synced": true, "availability_zone": null, "alive": true, "configurations": {"device_mappings": {"physnet1": ["ens590a255c847e", "ens61730c512d2e"], "physnetnew": ["ens74c23d91936f"]}, "extensions": [], "resource_provider_bandwidths": {"ens590a255c847e": {"egress": 1000, "ingress": 1000}, "ens61730c512d2e": {"egress": 1000, "ingress": 1000}, "ens74c23d91936f": {"egress": 1000, "ingress": 1000}}, "resource_provider_inventory_defaults": {"allocation_ratio": 1.0, "min_unit": 1, "step_size": 1, "reserved": 0}}}]} http_log_resp /home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-fullstack/lib/python3.6/site-packages/neutronclient/common/utils.py:204

  
  Logs: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_1de/697251/7/check/neutron-fullstack/1deb02b/testr_results.html.gz

  
  [1] https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_1de/697251/7/check/neutron-fullstack/1deb02b/controller/logs/dsvm-fullstack-logs/TestPlacementBandwidthReport.test_configurations_are_synced_towards_placement_NIC-Switch-agent_.txt.gz

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1856319/+subscriptions



References