← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 2003534] Re: neutron-keepalived-state-change unconditional debug mode

 

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/871274
Committed: https://opendev.org/openstack/neutron/commit/1a3bdff18abef093c0633bd39187f5a0e582535f
Submitter: "Zuul (22348)"
Branch:    master

commit 1a3bdff18abef093c0633bd39187f5a0e582535f
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Thu Jan 19 20:11:09 2023 +0100

    Honor debug mode in keepalived-state-change script logs
    
    This patch removes the config option "debug" override done
    during the script initialization.
    
    Closes-Bug: #2003534
    Change-Id: I403d73a1f35cb6314c814f25628a83d3e111e0fe


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2003534

Title:
  neutron-keepalived-state-change unconditional debug mode

Status in neutron:
  Fix Released

Bug description:
  In line
  https://opendev.org/openstack/neutron/src/branch/master/neutron/agent/l3/keepalived_state_change.py#L172
  there is a `conf.set_override('debug', True)` which enables debug mode
  for neutron-keepalived-state-change.

  This means any setup by the operator in the configuration file is
  ignored.

  In certain scenarios the log can flood the system with messages like
  the following:

  Jan 18 00:16:57 cloudnet1005 neutron-keepalived-state-change:
  2023-01-18 00:16:57.922 3355 DEBUG neutron.agent.linux.ip_lib [-] IP
  monitor qrouter-d93771ba-2711-4f88-804a-8df6fd03978a; Adding IP
  address: {'family': 2, '__pad': (), 'ifindex': 3, 'state': 16,
  'flags': 0, 'ndm_type': 1, 'attrs': [('NDA_DST', '172.16.7.73'),
  ('NDA_LLADDR', 'fa:16:3e:5f:59:1d'), ('NDA_PROBES', 1),
  ('NDA_CACHEINFO', {'ndm_confirmed': 4582, 'ndm_used': 241,
  'ndm_updated': 0, 'ndm_refcnt': 2})], 'header': {'length': 76, 'type':
  28, 'flags': 0, 'sequence_number': 0, 'pid': 0, 'error': None,
  'target': 'qrouter-d93771ba-2711-4f88-804a-8df6fd03978a', 'stats':
  Stats(qsize=0, delta=0, delay=0)}, 'event': 'RTM_NEWNEIGH'} to the
  queue. read_ip_updates /usr/lib/python3/dist-
  packages/neutron/agent/linux/ip_lib.py:1482

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2003534/+subscriptions



References