yahoo-eng-team team mailing list archive

[OpenStack Infra <1889737@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/823637
Committed: https://opendev.org/openstack/neutron/commit/3e1e2d63b3383d28c9a36b00000ab89caffa3829
Submitter: "Zuul (22348)"
Branch:    master

commit 3e1e2d63b3383d28c9a36b00000ab89caffa3829
Author: yatinkarel <ykarel@xxxxxxxxxx>
Date:   Thu Jan 6 04:49:03 2022 +0000

    Enable rpc notifications only when rpc_workers >= 1
    
    rpc_workers can be set < 1 with 'ovn' backend when no
    other agent is running apart from ovn agents to
    consume these rpc notifications.
    
    Add and apply disable_notifications decorator on
    methods which do rpc cast calls to agents, the
    decorator makes the caller method execute only
    when rpc_workers >=1. This patch not changing
    default behavior and utilizes the rpc_workers config option
    to enable rpc notification on resources updates only when
    rpc_workers >= 1.
    
    Also set rpc_workers=0 in ovn jobs to cover this scenario.
    
    Closes-Bug: #1889737
    Closes-Bug: #1992352
    Change-Id: I700fe2cd422bc1eb8b5144ec116e7f0a60238419


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1889737

Title:
  [OVN] Stop using neutron.api.rpc.handlers.resources_rpc with OVN as a
  backend

Status in neutron:
  Fix Released

Bug description:
  I noticed that in devstack master we have a lot of logs like:

  Jul 21 08:18:13.371897 ubuntu-bionic-rax-iad-0018525571 neutron-
  server[6599]: DEBUG neutron.api.rpc.handlers.resources_rpc [None
  req-968a9155-c80a-4fbc-9c10-bcfca6ba372d None None] Pushing event
  updated for resources: {'Port':
  ['ID=fedef62e-0a31-4136-a693-4b4d3bab289e,revision_number=5']}
  {{(pid=6988) push
  /opt/stack/neutron/neutron/api/rpc/handlers/resources_rpc.py:243}}

  
  That means we're pushing resources updates via RPC, but it is not needed with OVN as a backend, because there is no consumer of those messages.

  Lets try to stop doing it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1889737/+subscriptions