yahoo-eng-team team mailing list archive

[kay <2006770@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

If a project has two servers with 10.10.10.10 and 10.10.10.109 IPs, the
"curl -s 'https://nova:443/v2.1/servers?ip=10.10.10.10'" request returns
two servers in a response.

This happens because neutron API has an "ip-substring-filtering"
extension turned on:

$ curl -s "https://neutron/v2.0/extensions"; -H "X-Auth-Token: ${OS_AUTH_TOKEN}" | jq -r '.extensions[]|select(.alias=="ip-substring-filtering")'
{
  "name": "IP address substring filtering",
  "alias": "ip-substring-filtering",
  "description": "Provides IP address substring filtering when listing ports",
  "updated": "2017-11-28T09:00:00-00:00",
  "links": []
}

And there is no possibility to filter IPs with an exact match like it's
done with a
"https://neutron/v2.0/ports?fixed_ips=ip_address%3D10.10.10.10"; call.

----------------------------------------------------------------

Another problem is that ip/ip6 fields are marked as regexp in both
SCHEMA and CLI:

https://github.com/openstack/nova/blob/49aa40394a4857a06191b05ea3b15913f328a8d0/nova/api/openstack/compute/schemas/servers.py#L638-L639
(values which are not regexp compatible are rejected on the early stage)

$ openstack server list --help | grep -- --ip
                             [--ip <ip-address-regex>]
                             [--ip6 <ip-address-regex>] [--name <name-regex>]
  --ip <ip-address-regex>
  --ip6 <ip-address-regex>

But they are not considered as regexp afterwards. Moreover the
https://github.com/openstack/nova/blob/a2964417822bd1a4a83fa5c27282d2be1e18868a/nova/compute/api.py#L3028-L3039
mapping doesn't work, because "fixed_ip" is never allowed in
"search_opts" map.

Changing "fixed_ip" key to an "ip" key (BTW, there is no "fixed_ip6"
mapping, it also should be considered once someone decide to fix this
issue) breaks substring filtering, because the filter finally becomes
"'ip': '^10\\.10\\.10\\.10$'".

Therefore if there is no "substring filtering" neutron extension, the
regexp filter mappings must consider this (or even be removed).

And the final call: there should be a way for a user to define whether
user wants to use substr, exact match or regexp.

See also: https://stackoverflow.com/questions/64549906/how-openstack-
client-get-server-list-with-accurate-ip-address

** Affects: nova
     Importance: Undecided
         Status: New


** Tags: filter fixed ip neutron nova

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/2006770

Title:
  server list with IP filter doesn't work as expected

Status in OpenStack Compute (nova):
  New

Bug description:
  If a project has two servers with 10.10.10.10 and 10.10.10.109 IPs,
  the "curl -s 'https://nova:443/v2.1/servers?ip=10.10.10.10'" request
  returns two servers in a response.

  This happens because neutron API has an "ip-substring-filtering"
  extension turned on:

  $ curl -s "https://neutron/v2.0/extensions"; -H "X-Auth-Token: ${OS_AUTH_TOKEN}" | jq -r '.extensions[]|select(.alias=="ip-substring-filtering")'
  {
    "name": "IP address substring filtering",
    "alias": "ip-substring-filtering",
    "description": "Provides IP address substring filtering when listing ports",
    "updated": "2017-11-28T09:00:00-00:00",
    "links": []
  }

  And there is no possibility to filter IPs with an exact match like
  it's done with a
  "https://neutron/v2.0/ports?fixed_ips=ip_address%3D10.10.10.10"; call.

  ----------------------------------------------------------------

  Another problem is that ip/ip6 fields are marked as regexp in both
  SCHEMA and CLI:

  https://github.com/openstack/nova/blob/49aa40394a4857a06191b05ea3b15913f328a8d0/nova/api/openstack/compute/schemas/servers.py#L638-L639
  (values which are not regexp compatible are rejected on the early
  stage)

  $ openstack server list --help | grep -- --ip
                               [--ip <ip-address-regex>]
                               [--ip6 <ip-address-regex>] [--name <name-regex>]
    --ip <ip-address-regex>
    --ip6 <ip-address-regex>

  But they are not considered as regexp afterwards. Moreover the
  https://github.com/openstack/nova/blob/a2964417822bd1a4a83fa5c27282d2be1e18868a/nova/compute/api.py#L3028-L3039
  mapping doesn't work, because "fixed_ip" is never allowed in
  "search_opts" map.

  Changing "fixed_ip" key to an "ip" key (BTW, there is no "fixed_ip6"
  mapping, it also should be considered once someone decide to fix this
  issue) breaks substring filtering, because the filter finally becomes
  "'ip': '^10\\.10\\.10\\.10$'".

  Therefore if there is no "substring filtering" neutron extension, the
  regexp filter mappings must consider this (or even be removed).

  And the final call: there should be a way for a user to define whether
  user wants to use substr, exact match or regexp.

  See also: https://stackoverflow.com/questions/64549906/how-openstack-
  client-get-server-list-with-accurate-ip-address

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/2006770/+subscriptions