yahoo-eng-team team mailing list archive

[OpenStack Infra <2008257@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/874926
Committed: https://opendev.org/openstack/neutron/commit/827fbd01c306ce292e46b0d881bc3cc804202285
Submitter: "Zuul (22348)"
Branch:    master

commit 827fbd01c306ce292e46b0d881bc3cc804202285
Author: Pierre Riteau <pierre@xxxxxxxxxxxx>
Date:   Fri Feb 24 05:34:07 2023 +0100

    Normalise format of OVN agent heartbeat timestamp
    
    A recent change [1] to show the real heartbeat timestamp from OVN agents
    had a side effect of changing the timestamp format, which now includes a
    timezone:
    
        +-------------------+----------------------------------+
        | Field             | Value                            |
        +-------------------+----------------------------------+
        | last_heartbeat_at | 2023-02-23 14:12:07.471000+00:00 |
        +-------------------+----------------------------------+
    
    This unexpected format change causes some clients to fail to parse the
    response to GET /v2.0/agents.
    
    Normalise the format of the timestamp to remove timezone information.
    Also remove the microsecond part, which was not done for OVN, but is
    absent from other network agents.
    
    [1] https://review.opendev.org/c/openstack/neutron/+/844179
    
    Closes-Bug: #2008257
    Change-Id: I75a37fb9b49a421e4524da6b56ef8362ceb6107b


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2008257

Title:
  OVN agent heartbeat timestamp format changed unexpectedly

Status in neutron:
  Fix Released

Bug description:
  Following an upgrade from Wallaby to Yoga of a Neutron OVN deployment,
  I discovered that openstack-exporter would fail to return metrics for
  Neutron agent states with the following error:

  time="2023-02-23T10:49:33Z" level=error msg="Failed to collect metric
  for exporter: neutron, error: failed to collect metric: agent_state,
  error: parsing time \"2023-02-23 10:48:55.729000+00:00\": extra text:
  \"+00:00\"" source="exporter.go:123"

  I tracked it down to the following change which has also been
  backported to stable/branches (so a recent Wallaby would also be
  affected): https://review.opendev.org/c/openstack/neutron/+/844179

  With this change, heartbeat timestamp includes timezone when
  previously it didn't, causing clients such as the gophercloud library
  (which openstack-exporter uses) to fail parsing of the response.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2008257/+subscriptions