← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 2008767] Re: [sqlalchemy-20][vnpaas] SQL execution without transaction in progress

 

Reviewed:  https://review.opendev.org/c/openstack/neutron-vpnaas/+/875626
Committed: https://opendev.org/openstack/neutron-vpnaas/commit/792f2c65ec34b63ae8037a5328b7622320c4e1c4
Submitter: "Zuul (22348)"
Branch:    master

commit 792f2c65ec34b63ae8037a5328b7622320c4e1c4
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Tue Feb 28 09:34:05 2023 +0000

    [sqlalchemy-20] Add reader context to ``VPNPluginDb`` get methods
    
    The following methods are now called from inside a reader context:
    * ``VPNPluginDb.get_ikepolicy``
    * ``VPNPluginDb.get_ikepolicies``
    * ``VPNPluginDb.get_ipsecpolicy``
    * ``VPNPluginDb.get_ipsecpolicies``
    * ``VPNPluginDb._get_vpnservice``
    * ``VPNPluginDb.get_vpnservice``
    * ``VPNPluginDb.get_vpnservices``
    * ``VPNPluginDb.get_endpoint_group``
    * ``VPNPluginDb.get_endpoint_groups``
    
    This patch is also adding the writer context to
    ``BaseIPsecVPNDriver.create_vpnservice``.
    
    Closes-Bug: #2008767
    Closes-Bug: #2008001
    Change-Id: Ic22eb356c3157713a53cd71a366b946aa57ab042


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2008767

Title:
  [sqlalchemy-20][vnpaas] SQL execution without transaction in progress

Status in neutron:
  Fix Released

Bug description:
  The following methods are not called from inside a DB context:
  * ``VPNPluginDb.get_ikepolicy``
  * ``VPNPluginDb.get_ikepolicies``
  * ``VPNPluginDb.get_ipsecpolicy``
  * ``VPNPluginDb.get_ipsecpolicies``
  * ``VPNPluginDb._get_vpnservice``
  * ``VPNPluginDb.get_vpnservice``
  * ``VPNPluginDb.get_vpnservices``
  * ``VPNPluginDb.get_endpoint_group``
  * ``VPNPluginDb.get_endpoint_groups``

  Logs: https://paste.opendev.org/show/bNT4RdGsrx0DlI6ja2tS/

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2008767/+subscriptions



References