← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 2009804] Re: [OVN] Method ``get_port_qos`` should always return 2 values

 

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/876945
Committed: https://opendev.org/openstack/neutron/commit/bffa642b351f7fc3bb5cfb7a1bb2a3499c4b4506
Submitter: "Zuul (22348)"
Branch:    master

commit bffa642b351f7fc3bb5cfb7a1bb2a3499c4b4506
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Wed Mar 8 09:08:33 2023 +0100

    [OVN] Method ``get_port_qos`` should always return 2 values
    
    The method ``neutron.agent.ovn.agent.ovsdb.get_port_qos`` should
    always return 2 values, even when the LSP is not present. This
    patch:
    * fixes the output, returning 2 values
    * catches the exception raised when the LSP is not present in the
      OVN NB database
    * returns the default max_kbps and min_kbps values (0, 0).
    
    Closes-Bug: #2009804
    Change-Id: I03ea78fcc5825e35c07dda1aa790769aa918dd8a


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2009804

Title:
  [OVN] Method ``get_port_qos`` should always return 2 values

Status in neutron:
  Fix Released

Bug description:
  The method ``neutron.agent.ovn.agent.ovsdb.get_port_qos`` should
  always return 2 values. This is not happening in the (very rare) case
  of not finding the port logical_switch_port. In this case [1] we are
  only returning one value (an empty dictionary).

  [1]https://github.com/openstack/neutron/blob/50dc9dd24377ddb04bcb7fc9be362894b6ed1490/neutron/agent/ovn/agent/ovsdb.py#L165

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2009804/+subscriptions



References