yahoo-eng-team team mailing list archive

[OpenStack Infra <1993005@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/horizon/+/874351
Committed: https://opendev.org/openstack/horizon/commit/a327842a25f904397be0c3c141ada1f9ac8050cd
Submitter: "Zuul (22348)"
Branch:    master

commit a327842a25f904397be0c3c141ada1f9ac8050cd
Author: Mohammed Naser <mnaser@xxxxxxxxxxxx>
Date:   Sun Feb 19 18:47:11 2023 +0000

    fix(swift): allow object creation
    
    It is currently not possible to create any new objects inside
    Swift as you'd always get an error that the new object name
    already exists all the time.
    
    This fixes that issue and enables you to upload files again.
    
    Closes-Bug: #1993005
    Related-Change-Id: Idfb90a327e94ccaa3263aaaad1d6d52fa46312f4
    Change-Id: Ib2f1aaae87820e8d5c4a6c9b01b6a6e9a5552952


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1993005

Title:
  Swift file upload fails on zed with "This name already exists." for
  non-existing files

Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in horizon package in Ubuntu:
  Triaged

Bug description:
  Swift file upload fails on zed with "This name already exists." for
  non-existing files.

  Please see attached screenshot for the behavior.

  I've narrowed this down to a change in 'function getObjectDetails' in
  swift.service.js.

  The 'Migrate to AngularJS v1.8.2' change in commit f044c4b0a3 updated
  the file with:

  @@ -297,9 +297,9 @@
         );
         if (ignoreError) {
           // provide a noop error handler so the error is ignored
  -        return promise.error(angular.noop);
  +        return promise.catch(angular.noop);
         }
  -      return promise.error(function () {
  +      return promise.catch(function onError() {
           toastService.add('error', gettext('Unable to get details of the object.'));
         });
       }

  If I revert these 2 lines of code, I'm able to upload a file again
  without the error, however I'm also able to upload it twice and
  overwrite the existing file the 2nd time.

  Update: Specifically reverting the first LOC to the following seems to
  fix this:

  return promise.error(angular.noop);

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1993005/+subscriptions