← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 2012662] Re: [sqlalchemy-20] Strings are not accepted for attribute names in loader options

 

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/878480
Committed: https://opendev.org/openstack/neutron/commit/e4da60740bb6ff3daad619d71c5771001e782094
Submitter: "Zuul (22348)"
Branch:    master

commit e4da60740bb6ff3daad619d71c5771001e782094
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Wed Mar 22 14:33:04 2023 +0100

    [sqlalchemy-20] Do not use strings for aatribute names in loader options
    
    The method ``get_l3_agents_by_router_ids`` is retrieving the
    ``RouterL3AgentBinding`` registers along with the ``Agent`` information.
    This left outer join should be explictly defined using the database
    model.
    
    Expected query:
      SELECT routerl3agentbindings.router_id AS ...
      FROM routerl3agentbindings
      LEFT OUTER JOIN agents ON agents.id = routerl3agentbindings.l3_agent_id
      WHERE routerl3agentbindings.router_id IN (XXX)
    
    Closes-Bug: #2012662
    Change-Id: Ife9ba5d774934d2cd1a86b3281b78e854d88de3c


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2012662

Title:
  [sqlalchemy-20] Strings are not accepted for attribute names in loader
  options

Status in neutron:
  Fix Released

Bug description:
  Error: https://paste.opendev.org/show/bRx0wp79NzbmCoYrJwML/

  sqlalchemy.exc.ArgumentError: Strings are not accepted for attribute
  names in loader options; please use class-bound attributes directly.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2012662/+subscriptions



References