yahoo-eng-team team mailing list archive

[OpenStack Infra <2018130@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/881896
Committed: https://opendev.org/openstack/neutron/commit/2be53b1719e24d9a5be42505386a72ccdb26ef8f
Submitter: "Zuul (22348)"
Branch:    master

commit 2be53b1719e24d9a5be42505386a72ccdb26ef8f
Author: yatinkarel <ykarel@xxxxxxxxxx>
Date:   Sat Apr 29 12:34:33 2023 +0530

    [functional] Fix db_set use in test_cascading_del_in_txn
    
    With ovsdbapp-2.3.0 release 'db_set' method excepts
    if_exists(defaults to True) option.
    
    The default behavior made the test to fail
    as it was expecting transaction to fail.
    Adding if_exists=False so it persists the
    old behavior.
    
    Closes-Bug: #2018130
    Change-Id: I3dfdb0cce89cb860991a731b9a03313402956ddf


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2018130

Title:
  [master][functional] test_cascading_del_in_txn fails with
  ovsdbapp=2.3.0

Status in neutron:
  Fix Released

Bug description:
  With ovsdbapp==2.3.0 [1] releaase functional test
  neutron.tests.functional.agent.test_ovs_lib.OVSBridgeTestCase.test_cascading_del_in_txn
  fails consistently[2] as below:-

  ft1.7: neutron.tests.functional.agent.test_ovs_lib.OVSBridgeTestCase.test_cascading_del_in_txntesttools.testresult.real._StringException: Traceback (most recent call last):
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 182, in func
      return f(self, *args, **kwargs)
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/agent/test_ovs_lib.py", line 493, in test_cascading_del_in_txn
      self.assertRaises((RuntimeError, idlutils.RowNotFound),
    File "/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-functional-gate/lib/python3.10/site-packages/testtools/testcase.py", line 468, in assertRaises
      self.assertThat(our_callable, matcher)
    File "/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-functional-gate/lib/python3.10/site-packages/testtools/testcase.py", line 481, in assertThat
      raise mismatch_error
  testtools.matchers._impl.MismatchError: <function OVSBridgeTestCase.test_cascading_del_in_txn.<locals>.del_port_mod_iface at 0x7f35bbe8af80> returned None

  Seems to be caused with [3] as db_set will not fail if row is not
  found(if_exists=True).

  We need to add if_exists=false to keep the same behavior as test or
  update test so it succeed with current behavior

  [1] https://review.opendev.org/c/openstack/requirements/+/881736
  [2] https://zuul.opendev.org/t/openstack/builds?job_name=neutron-functional-with-uwsgi&project=openstack%2Fneutron&branch=master&skip=0
  [3] https://github.com/openstack/ovsdbapp/commit/6ab3f75388f583c99ac38d9c651f2529d68b617f

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2018130/+subscriptions