← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 2017127] Re: [ovn-octavia-provider] Fix member update according to the Octavia API definition

 

Reviewed:  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/880945
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/8beeeb9112f6c61758f844774bfe4c5d6e8c6a08
Submitter: "Zuul (22348)"
Branch:    master

commit 8beeeb9112f6c61758f844774bfe4c5d6e8c6a08
Author: Fernando Royo <froyo@xxxxxxxxxx>
Date:   Thu Apr 20 13:04:33 2023 +0200

    Fix update member action
    
    Upon receipt of a member update request, certain attribute checks
    are done, which may result in an error and prevent the update from
    being successfully completed.
    
    As per [1], only the "admin_state_up" attribute holds significance
    in enabling or disabling members on the ovn-provider side during
    an update operation.
    
    This patch remove other checks are deemed unnecessary.
    
    [1] https://docs.openstack.org/api-ref/load-balancer/v2/?expanded=update-a-member-detail,list-pools-detail,create-pool-detail,batch-update-members-detail#update-a-member
    
    Closes-Bug: 2017127
    Change-Id: I388284968e27e0ad8ec7bb0a522aa2925b560146


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2017127

Title:
  [ovn-octavia-provider] Fix member update according to the Octavia API
  definition

Status in neutron:
  Fix Released

Bug description:
  Nowadays member parameters are checked in an update that are not able
  to modify by Octavia API, such as address, port or subnet_id for an
  existing member. According to the definition of the member update (and
  batch_update) the parameters supported by the ovn-provider is only the
  admin_state_up of the member, so it seems coherent to clean the code
  to just analyze this one.

  In fact, the current checks performed on the attributes (not editable
  in an update operation) trigger an error and the update does not
  finish correctly.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2017127/+subscriptions



References