yahoo-eng-team team mailing list archive

[OpenStack Infra <2017216@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/881198
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/5f27384805bd2dd50602d3656d5f5df6c284f897
Submitter: "Zuul (22348)"
Branch:    master

commit 5f27384805bd2dd50602d3656d5f5df6c284f897
Author: Fernando Royo <froyo@xxxxxxxxxx>
Date:   Fri Apr 21 10:14:50 2023 +0200

    Discard batch-update-members not valid request
    
    An out of sync has been identified between the changes applied
    over the OVN NB DB and Octavia DB when a batch-update-members
    includes some unsupported option for any of the member to be
    modified.
    
    To prevent such inconsistencies, this patch rejects the entire
    request if any of the proposed changes are identified as
    unsupported. The user will be notified of the reason for the
    rejection.
    
    Closes-Bug: 2017216
    Change-Id: I6e132ab5c23c9c53176612f74bb500e46c89024f


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2017216

Title:
  [ovn-octavia-provider] batch member update generates out of sync with
  Octavia DB

Status in neutron:
  Fix Released

Bug description:
  When a batch_update_members request [1] is sending not supported
  options (e.g. monitor_X) over a member already existing or a new one
  the OVN-provider applies the rest of changes for other members and
  skip the member with the not supported option. For each action
  executed (create/delete/update) an updated status is sent to Octavia
  API, and for the skipped members and UnsupportedOptionError is
  replied.

  The weird thing here is that Octavia API is not applying the other
  member changes a soon as it receives the UnsupportedOptionError update
  status for the skipped member, and at this way we are generating a out
  of sync between the info in Octavia DB and the OVN NB DB side.

  A reproducer is logged in
  https://paste.openstack.org/show/bU4o2ylJOg7XLXgVXKps/

  [1] https://docs.openstack.org/api-ref/load-
  balancer/v2/?expanded=update-a-member-detail,list-pools-detail,create-
  pool-detail,batch-update-members-detail#batch-update-members

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2017216/+subscriptions