← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 2024447] [NEW] [OVN] "_load_hash_ring" is couting the hash righ nodes without opening a DB txn

 

Public bug reported:

In [1], we are accessing to the DB calling "count_offline_nodes". This
call is issuing a DB request without opening a txn (reader context, for
example).

The methods "get_active_nodes" and "count_offline_nodes" are calling
query.all() and query.count() outside the reader context that is created
in "_get_nodes_query".

[1]https://review.opendev.org/c/openstack/neutron/+/886005/2/neutron/common/ovn/hash_ring_manager.py

** Affects: neutron
     Importance: Undecided
         Status: In Progress

** Description changed:

  In [1], we are accessing to the DB calling "count_offline_nodes". This
  call is issuing a DB request without opening a txn (reader context, for
  example).
  
+ The methods "get_active_nodes" and "count_offline_nodes" are calling
+ query.all() and query.count() outside the reader context that is created
+ in "_get_nodes_query".
  
- [1]https://review.opendev.org/c/openstack/neutron/+/886005/2/neutron/common/ovn/hash_ring_manager.py#76
+ [1]https://review.opendev.org/c/openstack/neutron/+/886005/2/neutron/common/ovn/hash_ring_manager.py

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2024447

Title:
  [OVN] "_load_hash_ring" is couting the hash righ nodes without opening
  a DB txn

Status in neutron:
  In Progress

Bug description:
  In [1], we are accessing to the DB calling "count_offline_nodes". This
  call is issuing a DB request without opening a txn (reader context,
  for example).

  The methods "get_active_nodes" and "count_offline_nodes" are calling
  query.all() and query.count() outside the reader context that is
  created in "_get_nodes_query".

  [1]https://review.opendev.org/c/openstack/neutron/+/886005/2/neutron/common/ovn/hash_ring_manager.py

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2024447/+subscriptions



Follow ups