yahoo-eng-team team mailing list archive

[OpenStack Infra <2034016@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/893602
Committed: https://opendev.org/openstack/neutron/commit/f7489abaf822574f6d8c01b72495788e07d756d3
Submitter: "Zuul (22348)"
Branch:    master

commit f7489abaf822574f6d8c01b72495788e07d756d3
Author: yatinkarel <ykarel@xxxxxxxxxx>
Date:   Mon Sep 4 13:33:29 2023 +0530

    [UT] Adjust autogen_process_directives for alembic-1.12.0+
    
    With [1] included in alembic-1.12.0 the unit test
    test_autogen_process_directives fails as it was
    expecting 'type_' param in Autogenerated output.
    But this is not included with 1.12.0 by default,
    this patch enhances the regex to care only for relevant
    parameters.
    
    [1] https://github.com/sqlalchemy/alembic/commit/733197e
    Closes-Bug: #2034016
    Change-Id: I088cc4b260cccf6be2963d23a76a05f11cfccf2c


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2034016

Title:
  openstack-tox-py310-with-sqlalchemy-master broken with latest alembic
  commit

Status in neutron:
  Fix Released

Bug description:
  The job runs with latest alembic/sqlalchemy commits and is broken with
  recent alembic commit[1].

  Test neutron.tests.unit.db.test_migration.TestCli.test_autogen_process_directives fails as below:-
  ft1.27: neutron.tests.unit.db.test_migration.TestCli.test_autogen_process_directivestesttools.testresult.real._StringException: Traceback (most recent call last):
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 178, in func
      return f(self, *args, **kwargs)
    File "/usr/lib/python3.10/unittest/mock.py", line 1379, in patched
      return func(*newargs, **newkeywargs)
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/unit/db/test_migration.py", line 708, in test_autogen_process_directives
      self.assertThat(
    File "/home/zuul/src/opendev.org/openstack/neutron/.tox/py310/lib/python3.10/site-packages/testtools/testcase.py", line 481, in assertThat
      raise mismatch_error
  testtools.matchers._impl.MismatchError: "# ### commands auto generated by Alembic - please adjust! ###\n    op.drop_constraint('user', 'uq_user_org')\n    op.drop_column('user', 'organization_name')\n    # ### end Alembic commands ###" does not match /(# )?### commands\ auto\ generated\ by\ Alembic\ \-\ please\ adjust!\ \#\#\#\\n\ \ \ \ op\.drop_constraint\('user',\ 'uq_user_org',\ type_=None\)\\n\ \ \ \ op\.drop_column\('user',\ 'organization_name'\)\\n\ \ \ \ (# )?### end\ Alembic\ commands\ \#\#\#/
   
  Example failure:-
  https://76069f8f7ed36a9de08a-3a08f5dd30775d36f5503265ac08cfa4.ssl.cf2.rackcdn.com/886988/10/check/openstack-tox-py310-with-sqlalchemy-master/70a282c/testr_results.html

  [1]
  https://github.com/sqlalchemy/alembic/commit/733197e0e794ed6aec3e21542257d6cec5bb7d1f

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2034016/+subscriptions