yahoo-eng-team team mailing list archive

[OpenStack Infra <2034952@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/manila-ui/+/894389
Committed: https://opendev.org/openstack/manila-ui/commit/9c7912238dd3367d6a97b454a375390a0c548e3d
Submitter: "Zuul (22348)"
Branch:    master

commit 9c7912238dd3367d6a97b454a375390a0c548e3d
Author: Corey Bryant <corey.bryant@xxxxxxxxxxxxx>
Date:   Fri Sep 8 14:22:49 2023 -0400

    Fix test failures with Django 4.x
    
    The wsgi.input environment variable is expected to be a stream
    instead of a string.
    
    Closes-Bug: #2034952
    Change-Id: I72e88dcf07c90051ddf1c9030a2466501482de5d


** Changed in: manila-ui
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/2034952

Title:
  manila-ui failures with Django 4.2.4

Status in OpenStack Dashboard (Horizon):
  In Progress
Status in manila-ui:
  Fix Released

Bug description:
  Running unit tests with Django==4.2.4 results in 124 errors. They seem
  to be limited to the same error:

  ======================================================================
  ERROR: test_migration_get_progress (manila_ui.tests.dashboards.admin.shares.test_forms.ManilaDashboardsAdminMigrationFormTests)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/home/corey/pkg/bobcat/upstream/manila-ui/manila_ui/tests/dashboards/admin/shares/test_forms.py", line 29, in setUp
      self.request = wsgi.WSGIRequest(FAKE_ENVIRON)
    File "/home/corey/pkg/bobcat/upstream/manila-ui/.tox/py3/lib/python3.10/site-packages/django/core/handlers/wsgi.py", line 78, in __init__
      self._stream = LimitedStream(self.environ["wsgi.input"], content_length)
    File "/home/corey/pkg/bobcat/upstream/manila-ui/.tox/py3/lib/python3.10/site-packages/django/core/handlers/wsgi.py", line 24, in __init__
      self._read = stream.read
  AttributeError: 'str' object has no attribute 'read'

  To reproduce:
  git clone https://opendev.org/openstack/manila-ui; cd manila-ui
  tox -e py3
  .tox/py3/bin/pip3 install Django==4.2.4
  tox -e py3

  
  I'm also hitting a similar error that seems to need fixing in horizon:

  ======================================================================
  ERROR: test_view_1_None (manila_ui.tests.dashboards.project.user_messages.tests.UserMessagesViewTests)
  ----------------------------------------------------------------------
  Traceback (most recent call last):                                                                                 
    File "/home/corey/pkg/bobcat/upstream/manila-ui/.tox/py3/lib/python3.10/site-packages/ddt.py", line 220, in wrapper
      return func(self, *args, **kwargs)                   
    File "/home/corey/pkg/bobcat/upstream/manila-ui/manila_ui/tests/dashboards/project/user_messages/tests.py", line 44, in test_view
      self.assertNoMessages()                              
    File "/home/corey/pkg/bobcat/upstream/manila-ui/.tox/py3/lib/python3.10/site-packages/horizon/test/helpers.py", line 195, in assertNoMessages
      self.assertMessageCount(response, success=0, warn=0, info=0, error=0)
    File "/home/corey/pkg/bobcat/upstream/manila-ui/.tox/py3/lib/python3.10/site-packages/horizon/test/helpers.py", line 203, in assertMessageCount
      temp_req = self.client.request(**{'wsgi.input': None})
    File "/home/corey/pkg/bobcat/upstream/manila-ui/.tox/py3/lib/python3.10/site-packages/django/test/client.py", line 886, in request
      response = self.handler(environ)                     
    File "/home/corey/pkg/bobcat/upstream/manila-ui/.tox/py3/lib/python3.10/site-packages/django/test/client.py", line 168, in __call__
      request = WSGIRequest(environ)                       
    File "/home/corey/pkg/bobcat/upstream/manila-ui/.tox/py3/lib/python3.10/site-packages/django/core/handlers/wsgi.py", line 79, in __init__
      self._stream = LimitedStream(self.environ["wsgi.input"], content_length)
    File "/home/corey/pkg/bobcat/upstream/manila-ui/.tox/py3/lib/python3.10/site-packages/django/core/handlers/wsgi.py", line 25, in __init__
      self._read = stream.read                        
  AttributeError: 'NoneType' object has no attribute 'read'

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/2034952/+subscriptions