yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #92858
[Bug 1943639] Re: project/instances/attach_interface has O(N) scaling time complexity for opening form
This bug was fixed in the package horizon - 3:18.3.5-0ubuntu2.2
---------------
horizon (3:18.3.5-0ubuntu2.2) focal; urgency=medium
* d/p/get-ports-directly.patch: Get ports directly instead of via
loop (LP: #1943639).
-- Nicolas Bock <nicolas.bock@xxxxxxxxxxxxx> Tue, 22 Aug 2023 20:58:11
+0000
** Changed in: horizon (Ubuntu Focal)
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1943639
Title:
project/instances/attach_interface has O(N) scaling time complexity
for opening form
Status in Ubuntu Cloud Archive:
Fix Released
Status in Ubuntu Cloud Archive ussuri series:
Fix Committed
Status in Ubuntu Cloud Archive victoria series:
Fix Committed
Status in Ubuntu Cloud Archive wallaby series:
Fix Committed
Status in Ubuntu Cloud Archive xena series:
Fix Released
Status in OpenStack Dashboard (Horizon):
Fix Released
Status in horizon package in Ubuntu:
Fix Released
Status in horizon source package in Focal:
Fix Released
Bug description:
[ Impact ]
The time complexity of opening the project/instances/attach_interface
form box is O(N) where N is the number of networks in the project with
a large prefactor.
This is due to
https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/dashboards/project/instances/utils.py#L210
Which loops over the networks and requests the ports associated with
the network. For large projects this scaling behavior can become
prohibitive.
The patch [1] addresses this issue by reducing the number of API calls
and hence the prefactor of the algorithm.
[ Test Plan ]
In order to reproduce the issue, create a Nova VM and then add many
networks. On the instances tab in the Horizon UI click on "attach
interface" for the VM. It will take a moment for the dialog to appear.
The exact time until the dialog appears will depend on the number of
networks linearly.
With [1] the time it takes for the dialog box to appear will be
significantly shorter.
[ Where problems could occur ]
The patch [1] affects the "attach interface" dialog box and could
break this UI feature in case something was wrong with the
implementation. It is also possible that due to a bug in the
implementation some networks are missing from the dialog.
[1] https://review.opendev.org/c/openstack/horizon/+/866895
To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1943639/+subscriptions
References