← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 2040172] Re: [OVN] OvnSbSynchronizer - clean/delete segmenthostmappings for unrelated hosts

 

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/899077
Committed: https://opendev.org/openstack/neutron/commit/3aafeefc8553fd637bad238ee236b1767d8548ea
Submitter: "Zuul (22348)"
Branch:    master

commit 3aafeefc8553fd637bad238ee236b1767d8548ea
Author: Harald Jensås <hjensas@xxxxxxxxxx>
Date:   Mon Oct 23 17:29:00 2023 +0200

    [OVN] DB sync host/physnet - filter on agent_type
    
    When syncing hostname and physical networks, filter neutron
    hosts on agent_type. Only segmenthostmappings for hosts
    with agent 'OVN Controller agent' should be cleaned up.
    
    Since change: I935186b6ee95f0cae8dc05869d9742c8fb3353c3 there
    is de-duplication of segmenthostmapping updates from agents.
    If the OVN DB sync clears/deletes mappings for hosts owned by
    other agents/plugins the mappings are never re-created.
    
    Closes-Bug: #2040172
    
    Change-Id: Iaf15e560e1b1ec31618b2ebc6206a938463c1094
    Signed-off-by: Harald Jensås <hjensas@xxxxxxxxxx>


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2040172

Title:
  [OVN] OvnSbSynchronizer - clean/delete segmenthostmappings for
  unrelated hosts

Status in neutron:
  Fix Released

Bug description:
  neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.ovn_db_sync.OvnSbSynchronizer

  When the `sync_hostname_and_physical_networks` method run's it will
  compare host physical_networks to mappings in neutrons
  `segmenthostmappings` table. Any mappings in neutron that is not seen
  on OVN chassis is then treated as "stale" and cleaned up.

  This is problematic when there are other plug-ins/agents involved, for
  example ML2 networking-baremetal[2]. Any segment-host mapping created
  for baremetal nodes are deleted from the database. And since there is
  de-duplication[1] on updates from agents - the segment-host mappings
  are not re-created unless services are re-started or the baremetal
  node is deleted and re-created in the ironic service.

  The OvnSbSynchronizer should not remove mappings unless they belong to
  OVN hosts.

  [1] https://opendev.org/openstack/neutron/commit/176503e610aee16cb5799a77466579bc55129450
  [2] https://opendev.org/openstack/networking-baremetal/src/branch/master/networking_baremetal/agent/ironic_neutron_agent.py

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2040172/+subscriptions



References