yahoo-eng-team team mailing list archive

[OpenStack Infra <2043030@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/nova/+/902183
Committed: https://opendev.org/openstack/nova/commit/99fe8c93a1cac2cb6fa59218ea9bf8687bf8d4df
Submitter: "Zuul (22348)"
Branch:    master

commit 99fe8c93a1cac2cb6fa59218ea9bf8687bf8d4df
Author: Ali Safari <alisafar1212@xxxxxxxxx>
Date:   Wed Nov 29 23:02:50 2023 +0330

    Fix traits to cpu flags mapping
    
    Following keys like HW_CPU_X86_SVM and HW_CPU_X86_VMX are placed in TRAITS_CPU_MAPPING as part of a tuple instead of being direct keys.
    This patch will flaten these tuples.
    Closes-Bug: #2043030
    
    Change-Id: Ia600ceb22c5939117095593b97ed94735c8f953c


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/2043030

Title:
  Flavors with trait:HW_CPU_X86_VMX='required' are not working properly

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  I'm having trouble with Flavor which have
  trait:HW_CPU_X86_VMX='required' as a requirement.

  I've checked the code and get_flags_by_flavor_specs at https://opendev.org/openstack/nova/src/commit/b64ecb0cc776bd3eced674b0f879bb23c8a4b486/nova/virt/libvirt/utils.py#L656 is expecting that each key in TRAITS_CPU_MAPPING is a string but as you can see HW_CPU_X86_VMX is actually part of a tuple (os_traits.HW_CPU_X86_VMX, os_traits.HW_CPU_X86_INTEL_VMX).
  and get_flags_by_flavor_specs fails to extract vmx flag from flavors properly.

  I've been experiencing this issue on Antelope and based on current
  state of master it's still out there.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/2043030/+subscriptions