yahoo-eng-team team mailing list archive

[OpenStack Infra <2041609@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/899469
Committed: https://opendev.org/openstack/neutron/commit/37384a4705e4ee1d8c044534459c9d48621dd537
Submitter: "Zuul (22348)"
Branch:    master

commit 37384a4705e4ee1d8c044534459c9d48621dd537
Author: elajkat <lajos.katona@xxxxxxxx>
Date:   Fri Oct 27 11:25:23 2023 +0200

    FIP QoS: check policy id before blindly updating FIP
    
    [1] changed FIP OvO for QoS update, but it seems that
    it introduced a regression when FIP is updated without
    QoS policy in the request.
    
    [1]: https://review.opendev.org/c/833667
    
    Closes-Bug: #2041609
    Change-Id: I254e1625c1a157e562df22ae2fd5c6e28971f812


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2041609

Title:
  FIP update removes QoS policy

Status in neutron:
  Fix Released

Bug description:
  When updating a FIP with QoS policy (even updating the description)
  overwrites the QoS policy id with None.

  $ openstack floating ip create public --qos-policy foo_qos_policy_0
  +---------------------+--------------------------------------+
  | Field               | Value                                |
  +---------------------+--------------------------------------+
  | created_at          | 2023-10-27T10:00:51Z                 |
  | description         |                                      |
  .....
  | id                  | bd2639aa-34a2-4d81-b655-24ca2106cac4 |
  ....
  | qos_policy_id       | 6396b46c-0a6f-4dd0-a916-e1607573a614 |
  ...
  +---------------------+--------------------------------------+
  $ openstack floating ip set bd2639aa-34a2-4d81-b655-24ca2106cac4 --description "my floatin ip with QoS"

  $ openstack floating ip show bd2639aa-34a2-4d81-b655-24ca2106cac4
  +---------------------+--------------------------------------+
  | Field               | Value                                |
  +---------------------+--------------------------------------+
  | created_at          | 2023-10-27T10:00:51Z                 |
  | description         |                                      |
  .....
  | id                  | bd2639aa-34a2-4d81-b655-24ca2106cac4 |
  ....
  | qos_policy_id       | None                                 |
  ...
  +---------------------+--------------------------------------+

  The issue is on master and seems was introduced with this patch [1]:
  [1]: https://review.opendev.org/c/openstack/neutron/+/833667

  As I see an extra condition (as was before [1]) is necessary here:
  https://opendev.org/openstack/neutron/src/commit/53f4fd6b9fcb4f8ba907bfbace342bf902fc55f7/neutron/db/l3_db.py#L1610-L1611

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2041609/+subscriptions