← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 2056199] Re: ``DvrDriver`` and ``OvnDriver`` incorrectly define distributed flag

 

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/911151
Committed: https://opendev.org/openstack/neutron/commit/06d48cb980d777514ffe9283eed0b59dcdb14345
Submitter: "Zuul (22348)"
Branch:    master

commit 06d48cb980d777514ffe9283eed0b59dcdb14345
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Tue Mar 5 02:34:30 2024 +0000

    ``OvnDriver`` and ``DvrHaDriver`` to use "distributed_support" variable
    
    ``OvnDriver`` and ``DvrHaDriver`` classes were using an incorrect
    variable name to define the DVR support, that should be
    "distributed_support" instead of "dvr_support".
    
    Closes-Bug: #2056199
    Change-Id: Id2ee080dde8cd094995e94564f2877a89e9cc5aa


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2056199

Title:
  ``DvrDriver`` and ``OvnDriver`` incorrectly define distributed flag

Status in neutron:
  Fix Released

Bug description:
  The class ``L3ServiceProvider`` defines the distributed support with
  the class variable "distributed_support" [1]. The classes
  ``DvrDriver`` and ``OvnDriver`` are using the variable "dvr_support"
  instead.

  The method to ensure a driver "ha" and "distributed" support uses
  "distributed_support" too [2].

  [1]https://github.com/openstack/neutron/blob/c4c14f9589b54cc518564f1e1679898d2729c9e2/neutron/services/l3_router/service_providers/base.py#L57
  [2]https://github.com/openstack/neutron/blob/c4c14f9589b54cc518564f1e1679898d2729c9e2/neutron/services/l3_router/service_providers/driver_controller.py#L273

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2056199/+subscriptions



References