← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 2042925] Re: DNS Integration throws expection logs entries were warnings would be sufficient

 

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/900212
Committed: https://opendev.org/openstack/neutron/commit/5fe5188ce513c928b45cbc890bed80d8d5a2106b
Submitter: "Zuul (22348)"
Branch:    master

commit 5fe5188ce513c928b45cbc890bed80d8d5a2106b
Author: Jayce Houtman <jhoutman@xxxxxxxxxxxxx>
Date:   Mon Nov 6 17:23:44 2023 +0100

    Change exception messages to error log messages for DNS integration.
    
    Change non-harmful stack trace errors for dns_exc.DNSDomainNotFound and
    dns_exc.DuplicateRecordSet to error log messages. This prevents the logs
    from filling with stack traces where error messages would have been
    sufficient enough.
    
    Closes-Bug: #2042925
    Change-Id: Icf1fff28bb560c506392f16c579de6d92cd56c23


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2042925

Title:
  DNS Integration throws expection logs entries were warnings would be
  sufficient

Status in neutron:
  Fix Released

Bug description:
  
  The DNS Integration in the ML2 drivers generates exception LOG entries whenever dns_exc.DNSDomainNotFound and dns_exc.DuplicateRecordSet are triggered on the creation or deletion of DNS records. These exceptions occur if a duplicate record set is found or if the DNS domain is not located.

  The exceptions serve to alert the administrators that there was an
  issue with the record set's creation. However, I believe a warning
  would be sufficiently informative for the administrators to recognize
  that something did not proceed as anticipated, which would prevent
  stack traces in the logs. An error could also serve this purpose, but
  I think a warning is more suitable since the system remains
  operational when the exceptions are caught within Neutron.

  Example stack trace of a duplicate record set: https://jhcsmedia.com/?f=stack_trace_neutron_900212.txt
  The stack traces comes from our deployment which runs version 2023.1 deployed with Kolla-Ansible. We use OpenStack Designate as our DNS driver.

  I have already submitted a review to modify the exceptions to
  warnings, which also eliminates the catching of
  dns_exc.DuplicateRecordSet when removing DNS records. This change is
  based on the premise that duplicate record sets should not exist
  initially. https://review.opendev.org/c/openstack/neutron/+/900212

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2042925/+subscriptions



References