← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 2062965] Re: octavia/ovn: missed healthmon port cleanup

 

Reviewed:  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/916637
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/f034bab144b68cf96c538339e389c4cc7c6d7d63
Submitter: "Zuul (22348)"
Branch:    master

commit f034bab144b68cf96c538339e389c4cc7c6d7d63
Author: Fernando Royo <froyo@xxxxxxxxxx>
Date:   Mon Apr 22 15:47:46 2024 +0200

    Remove leftover OVN LB HM port upon deletion of a member
    
    When a load balancer pool has a Health Monitor associated with it,
    an OVN LB Health Monitor port is created for each backend member
    subnet added.
    
    When removing backend members, the OVN LB Health Monitor port is
    cleaned up only if no more members are associated with the Health
    Monitor pool. However, this assumption is incorrect. This patch
    corrects this behavior by checking instead if there are more members
    from the same subnet associated with the pool. It ensures that the
    OVN LB Health Monitor port is deleted only when the last member from
    the subnet is deleted. If the port is being used by another different
    LB Health Monitor, `_clean_up_hm_port` will handle it.
    
    Closes-Bug: #2062965
    Change-Id: I4c35cc5c6af14bb208f4313bb86e3519df0a30fa


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2062965

Title:
  octavia/ovn: missed healthmon port cleanup

Status in neutron:
  Fix Released

Bug description:
  Creating an octavia load-balancer with the ovn provider, adding a health-monitor and then members, octavia creates a neutron hm port in each subnet where a member was added.
  Removing the members again, the hm ports do not get cleaned up. The hm removal then cleans up one of the hm ports, the one that is in the subnet where the vip happens to be. The others are still left and do not get cleaned up by octavia. This of course will cause issues when subnets can later not be deleted due to being still populated by the orphaned ports.
  The cleanup logic simply does not match the hm port creation logic.

  Mitigating factors:
  * openstack loadbalancer delete --cascade does clean up all hm ports.
  * Deleting the health mon before removing the members also avoids the issue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2062965/+subscriptions