yahoo-eng-team team mailing list archive

[OpenStack Infra <2072154@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/923467
Committed: https://opendev.org/openstack/neutron/commit/a311606fcdae488e76c29e0e5e4035f8da621a34
Submitter: "Zuul (22348)"
Branch:    master

commit a311606fcdae488e76c29e0e5e4035f8da621a34
Author: Seyeong Kim <seyeong.kim@xxxxxxxxxxxxx>
Date:   Thu Jul 4 06:23:59 2024 +0000

    Checking pci_slot to avoid changing staus to BUILD forever
    
    Currently when sriov agent is enabled and migrating a non-sriov
    instance, non-sriov port status is frequently set to BUILD
    instead of ACTIVE.
    This is because the 'binding_activate' function in sriov-nic-agent sets it
    BUILD with get_device_details_from_port_id(as it calls _get_new_status).
    
    This patch checks network_ports in binding_activate and
    skip binding port if it is not sriov port
    
    Closes-Bug: #2072154
    Change-Id: I2d7702e17c75c96ca2f29749dccab77cb2f4bcf4


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2072154

Title:
  Port status goes BUILD when migrating non-sriov instance in sriov
  setting.

Status in neutron:
  Fix Released

Bug description:
  Port status goes BUILD when migrating non-sriov instance in sriov
  setting.

  Test

  1. Deploy Antelope with juju ( upstream also has the same code )
  2. Enable SRIOV
  3. create a vm without sriov nic. (test)
  4. migrate it to another host
  - openstack server migrate --live-migration --os-compute-api-version 2.30 --host node-04.maas test
  5. check port status
  - https://paste.ubuntu.com/p/RKGnP76MvB/

  nova-compute has neutron-sriov-nic-agent and neutron-ovn-metadata-
  agent

  So far, I've checked that

  ovn_monitor change it to ACTIVE but sriov-nic-agent change it back to
  BUILD by calling _get_new_status

  ./plugins/ml2/drivers/mech_sriov/agent/sriov_nic_agent.py
  binding_activate
  - get_device_details_from_port_id
  - get_device_details
  - _get_new_status < this makes status BUILD.

  so as running order is not fixed, sometimes it goes ACTIVE, sometimes
  BUILD.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2072154/+subscriptions