yahoo-eng-team team mailing list archive

[Rodolfo Alonso <2073743@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The method ``ProcessMonitor._check_child_processes`` releases the thread
executor inside a method that creates a lock for the resource
"_check_child_processes". Despite this resource is not used anywhere
else (at least for this instance), this could lead to a potential
deadlock.

The current implementation of ``lockutils.synchronized`` with the
default value "external=False" and "fair=False" is a
``threading.Lock()`` instance. The goal of this lock is, precisely, to
execute the code inside the locked code without any interruption and
then to be able to release the executor.

** Affects: neutron
     Importance: Medium
     Assignee: Rodolfo Alonso (rodolfo-alonso-hernandez)
         Status: In Progress

** Changed in: neutron
   Importance: Undecided => Medium

** Changed in: neutron
     Assignee: (unassigned) => Rodolfo Alonso (rodolfo-alonso-hernandez)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2073743

Title:
  ``ProcessMonitor._check_child_processes`` cannot release the GIL
  inside a locked method

Status in neutron:
  In Progress

Bug description:
  The method ``ProcessMonitor._check_child_processes`` releases the
  thread executor inside a method that creates a lock for the resource
  "_check_child_processes". Despite this resource is not used anywhere
  else (at least for this instance), this could lead to a potential
  deadlock.

  The current implementation of ``lockutils.synchronized`` with the
  default value "external=False" and "fair=False" is a
  ``threading.Lock()`` instance. The goal of this lock is, precisely, to
  execute the code inside the locked code without any interruption and
  then to be able to release the executor.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2073743/+subscriptions