yahoo-eng-team team mailing list archive

[OpenStack Infra <2076163@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/nova/+/925826
Committed: https://opendev.org/openstack/nova/commit/f63029b461b81ad93e0681973ed9b5bfca405d5a
Submitter: "Zuul (22348)"
Branch:    master

commit f63029b461b81ad93e0681973ed9b5bfca405d5a
Author: melanie witt <melwittt@xxxxxxxxx>
Date:   Tue Aug 6 20:29:22 2024 +0000

    libvirt: Remove node device XML validate flags
    
    Node device XML validation flags [1]:
    
      VIR_NODE_DEVICE_(CREATE|DEFINE)_XML_VALIDATE
    
    were added in libvirt 8.10.0 but we support older libvirt versions
    which will raise an AttributeError when flag access is attempted.
    
    We are not currently using the flags (nothing calling with
    validate=True) so this removes the flags from the code entirely. If the
    flags are needed in the future, they can be added again at that time.
    
    Closes-Bug: #2076163
    
    [1] https://github.com/libvirt/libvirt/commit/d8791c3c7caa6e3cadaf98a5a2c94b232ac30fed
    
    Change-Id: I015d9b7cad413986058da4d29ca7711c844bfa84


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/2076163

Title:
  Persistent mdev support does not work with < libvirt 8.10 due to
  missing VIR_NODE_DEVICE_CREATE_XML_VALIDATE

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  The persistent mdev feautre passes that flag but that flag was only
  supported since libvirt 8.10.0 so with older libvirt like 7.3.0 (min
  persistent mdev) or 8.0.0 (ubuntu 22.04) the persistent mdev feature
  cannot be enabled as nova-compute will fail due to the missing
  constant.

  XML validation is just a nice to have feature so we can make that flag
  optional and only pass it if libvirt is >= 8.10.0

  https://github.com/openstack/nova/commit/74befb68a79f8bff823fe067e0054504391ee179#diff-67d0163175a798156def4ec53c18fa2ce6eba79b6400fa833a9219d3669e9a11R1267
  https://github.com/libvirt/libvirt/commit/d8791c3c7caa6e3cadaf98a5a2c94b232ac30fed

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/2076163/+subscriptions