yahoo-eng-team team mailing list archive

[OpenStack Infra <2034035@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/horizon/+/893650
Committed: https://opendev.org/openstack/horizon/commit/9c75ebba01cc58c77a7114226ebaeedbe033962a
Submitter: "Zuul (22348)"
Branch:    master

commit 9c75ebba01cc58c77a7114226ebaeedbe033962a
Author: Tobias Urdin <tobias.urdin@xxxxxxxxx>
Date:   Mon Sep 4 13:03:15 2023 +0000

    Fix allowed address pair row unique ID
    
    This fixes so that the ID for the allowed
    address pair rows is unique if it's the
    same ip_address range but different
    mac_address.
    
    Closes-Bug: 2034035
    Change-Id: I49e84568ef7cfbc1547258305f2101bffe5bdea5


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/2034035

Title:
  neutron allowed address pair with same ip address causes ValueError

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  when managing allowed address pairs in horizon for a neutron port and
  you create two identical ip_address but with different mac_address,
  horizon crashes because the id in the table is the same, see below
  traceback.

  solution is to concat mac_address if set in the ID for that row

  Traceback (most recent call last):
    File "/usr/lib/python3.6/site-packages/django/core/handlers/exception.py", line 47, in inner
      response = get_response(request)
    File "/usr/lib/python3.6/site-packages/django/core/handlers/base.py", line 181, in _get_response
      response = wrapped_callback(request, *callback_args, **callback_kwargs)
    File "/usr/lib/python3.6/site-packages/horizon/decorators.py", line 51, in dec
      return view_func(request, *args, **kwargs)
    File "/usr/lib/python3.6/site-packages/horizon/decorators.py", line 35, in dec
      return view_func(request, *args, **kwargs)
    File "/usr/lib/python3.6/site-packages/horizon/decorators.py", line 35, in dec
      return view_func(request, *args, **kwargs)
    File "/usr/lib/python3.6/site-packages/horizon/decorators.py", line 111, in dec
      return view_func(request, *args, **kwargs)
    File "/usr/lib/python3.6/site-packages/horizon/decorators.py", line 83, in dec
      return view_func(request, *args, **kwargs)
    File "/usr/lib/python3.6/site-packages/django/views/generic/base.py", line 70, in view
      return self.dispatch(request, *args, **kwargs)
    File "/usr/lib/python3.6/site-packages/django/views/generic/base.py", line 98, in dispatch
      return handler(request, *args, **kwargs)
    File "/usr/lib/python3.6/site-packages/horizon/tabs/views.py", line 156, in post
      return self.get(request, *args, **kwargs)
    File "/usr/lib/python3.6/site-packages/horizon/tabs/views.py", line 135, in get
      handled = self.handle_table(self._table_dict[table_name])
    File "/usr/lib/python3.6/site-packages/horizon/tabs/views.py", line 116, in handle_table
      handled = tab._tables[table_name].maybe_handle()
    File "/usr/lib/python3.6/site-packages/horizon/tables/base.py", line 1802, in maybe_handle
      return self.take_action(action_name, obj_id)
    File "/usr/lib/python3.6/site-packages/horizon/tables/base.py", line 1644, in take_action
      response = action.multiple(self, self.request, obj_ids)
    File "/usr/lib/python3.6/site-packages/horizon/tables/actions.py", line 305, in multiple
      return self.handle(data_table, request, object_ids)
    File "/usr/lib/python3.6/site-packages/horizon/tables/actions.py", line 760, in handle
      datum = table.get_object_by_id(datum_id)
    File "/usr/lib/python3.6/site-packages/horizon/tables/base.py", line 1480, in get_object_by_id
      % matches)
  ValueError: Multiple matches were returned for that id: [<PortAllowedAddressPair: {'mac_address': 'fa:16:3e:9c:5d:cc', 'ip_address': '192.168.0.0/24'}>, <PortAllowedAddressPair: {'mac_address': 'fa:16:3e:e7:08:67', 'ip_address': '192.168.0.0/24'}>].

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/2034035/+subscriptions