← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 2075959] Re: NUMATopologyFilter pagesize logs are missleading

 

Reviewed:  https://review.opendev.org/c/openstack/nova/+/926223
Committed: https://opendev.org/openstack/nova/commit/4678bcbb064da580500b1dbeddb0bdfdeac074ef
Submitter: "Zuul (22348)"
Branch:    master

commit 4678bcbb064da580500b1dbeddb0bdfdeac074ef
Author: Stephen Finucane <stephenfin@xxxxxxxxxx>
Date:   Tue Aug 13 17:24:31 2024 +0100

    hardware: Correct log
    
    We currently get the following error message if attempting to fit a
    guest with hugepages on a node that doesn't have enough:
    
      Host does not support requested memory pagesize, or not enough free
      pages of the requested size. Requested: -2 kB
    
    Correct this, removing the kB suffix and adding a note on the meaning of
    the negative values, like we have for the success path.
    
    Change-Id: I247dc0ec03cd9e5a7b41f5c5534bdfb1af550029
    Signed-off-by: Stephen Finucane <stephenfin@xxxxxxxxxx>
    Closes-Bug: #2075959


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/2075959

Title:
  NUMATopologyFilter pagesize logs are missleading

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  When the instance request mem pages via symbolic names (e.g. "large"
  instead of specifying the exact size) and the instance does not fit to
  a NUMA cell due to the memory requirements nova logs are confusing:

  ./nova-scheduler-scheduler.log:2024-07-31 23:37:28.428 1 DEBUG
  nova.virt.hardware [None req-c3efb10b-641c-4066-a569-206226315366
  f05a486d957b4e6082293ce5e707009d 8c8a6763e6924cd3a94427af5f8ef6ee - -
  default default] Host does not support requested memory pagesize, or
  not enough free pages of the requested size. Requested: -2 kB
  _numa_fit_instance_cell /usr/lib/python3.9/site-
  packages/nova/virt/hardware.py:944

  This happens because the symbolic name translated to a negative
  integer placeholder inside nova. So when the field is printed it
  should be translated back to the symbolic name instead.

  
  https://github.com/openstack/nova/blob/bb2d7f9cad577f3a32cb9523e2b1d9a6d6db3407/nova/virt/hardware.py#L943-L946

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/2075959/+subscriptions



References