← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 2078432] Re: Port_hardware_offload_type API extension is reported as available but attribute is not set for ports

 

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/927577
Committed: https://opendev.org/openstack/neutron/commit/fbb7c9ae3d672796b72b796c53f89865ea6b3763
Submitter: "Zuul (22348)"
Branch:    master

commit fbb7c9ae3d672796b72b796c53f89865ea6b3763
Author: Slawek Kaplonski <skaplons@xxxxxxxxxx>
Date:   Fri Aug 30 11:50:55 2024 +0200

    Fix port_hardware_offload_type ML2 extension
    
    This patch fixes 2 issues related to that port_hardware_offload_type
    extension:
    
    1. API extension is now not supported by the ML2 plugin directly so if
       ml2 extension is not loaded Neutron will not report that API
       extension is available,
    2. Fix error 500 when creating port with hardware_offload_type
       attribute set but when binding:profile is not set (is of type
       Sentinel).
    
    Closes-bug: #2078432
    Closes-bug: #2078434
    Change-Id: Ib0038dd39d8d210104ee8a70e4519124f09292da


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2078432

Title:
  Port_hardware_offload_type API extension is reported as available but
  attribute is not set for ports

Status in neutron:
  Fix Released

Bug description:
  This API extension is implemented as ML2 plugin's extension but API
  extension is added also to the _supported_extension_aliases list
  directly in the ML2 plugin. Because of that even if ML2 extension is
  not really loaded, this API extension is reported as available.
  Because of that 'hardware_offload_type' attribute send from client is
  accepted by neutron but it is not saved in the db at all:

  
  $ openstack port create --network private --extra-property type=str,name=hardware_offload_type,value=switchdev test-port-hw-offload 

  
  +-------------------------+-----------------------------------------------------------------------------------------------------+                                                                                                                                                                                                                                                             
  | Field                   | Value                                                                                               |                                                                                                                                                                                                                                                             
  +-------------------------+-----------------------------------------------------------------------------------------------------+                                                                                                                                                                                                                                                             
  | admin_state_up          | UP                                                                                                  |                                                                                                                                                                                                                                                             
  | allowed_address_pairs   |                                                                                                     |                                                                                                                                                                                                                                                             
  | binding_host_id         |                                                                                                     |                                                                                                                                                                                                                                                             
  | binding_profile         |                                                                                                     |                                                                                                                                                                                                                                                             
  | binding_vif_details     |                                                                                                     |                                                                                                                                                                                                                                                             
  | binding_vif_type        | unbound                                                                                             |                                                                                                                                                                                                                                                             
  | binding_vnic_type       | normal                                                                                              |                                                                                                                                                                                                                                                             
  | created_at              | 2024-08-30T09:15:55Z                                                                                |                                                                                                                                                                                                                                                             
  | data_plane_status       | None                                                                                                |                                                                                                                                                                                                                                                             
  | description             |                                                                                                     |                                                                                                                                                                                                                                                             
  | device_id               |                                                                                                     |                                                                                                                                                                                                                                                             
  | device_owner            |                                                                                                     |                                                                                                                                                                                                                                                             
  | device_profile          | None                                                                                                |                                                                                                                                                                                                                                                             
  | dns_assignment          | None                                                                                                |                                                                                                                                                                                                                                                             
  | dns_domain              | None                                                                                                |                                                                                                                                                                                                                                                             
  | dns_name                | None                                                                                                |                                                                                                                                                                                                                                                             
  | extra_dhcp_opts         |                                                                                                     |                                                                                                                                                                                                                                                             
  | fixed_ips               | ip_address='10.0.0.24', subnet_id='db04fa1c-0f8c-40fb-acb3-d49c9cbd35f1'                            |                                                                                                                                                                                                                                                             
  |                         | ip_address='fda7:c49d:c9ff:0:f816:3eff:fe82:da10', subnet_id='1447fb43-1f10-489c-8f4b-51fb094d43ff' |                                                                                                                                                                                                                                                             
  | hardware_offload_type   | switchdev                                                                                           |                                                                                                                                                                                                                                                             
  | hints                   |                                                                                                     |                                                                                                                                                                                                                                                             
  | id                      | dc002862-960b-49dd-b254-60e2d76497ae                                                                |                                                                                                                                                                                                                                                             
  | ip_allocation           | None                                                                                                |                                                                                                                                                                                                                                                             
  | mac_address             | fa:16:3e:82:da:10                                                                                   |                                                                                                                                                                                                                                                             
  | name                    | test-port-hw-offload                                                                                |                                                                                                                                                                                                                                                             
  | network_id              | 563778fd-5c44-4fed-9a42-332385baff90                                                                |                                                                                                                                                                                                                                                             
  | numa_affinity_policy    | None                                                                                                |                                                                                                                                                                                                                                                             
  | port_security_enabled   | True                                                                                                |                                                                                                                                                                                                                                                             
  | project_id              | 89968c9415564ce38c19e2b06bfa216b                                                                    |                                                                                                                                                                                                                                                             
  | propagate_uplink_status | None                                                                                                |                                                                                                                                                                                                                                                             
  | resource_request        | None                                                                                                |                                                                                                                                                                                                                                                             
  | revision_number         | 1                                                                                                   |                                                                                                                                                                                                                                                             
  | qos_network_policy_id   | None                                                                                                |                                                                                                                                                                                                                                                             
  | qos_policy_id           | None                                                                                                |                                                                                                                                                                                                                                                             
  | security_group_ids      | 0ba13ab3-f5cf-41f6-bb3f-52955aa2d7ed                                                                |                                                                                                                                                                                                                                                             
  | status                  | DOWN                                                                                                |                                                                                                                                                                                                                                                             
  | tags                    |                                                                                                     |                                                                                                                                                                                                                                                             
  | trunk_details           | None                                                                                                |                                                                                                                                                                                                                                                             
  | updated_at              | 2024-08-30T09:15:55Z                                                                                |                                                                                                                                                                                                                                                             
  +-------------------------+-----------------------------------------------------------------------------------------------------+

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2078432/+subscriptions



References