yahoo-eng-team team mailing list archive

[OpenStack Infra <2068644@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/921663
Committed: https://opendev.org/openstack/neutron/commit/d8a4ad9167afd824a3f823d86a8fd33fb67c4abd
Submitter: "Zuul (22348)"
Branch:    master

commit d8a4ad9167afd824a3f823d86a8fd33fb67c4abd
Author: Will Szumski <will@xxxxxxxxxxxx>
Date:   Mon Jun 10 13:44:14 2024 +0100

    Correct logic error when associating FIP with OVN LB
    
    Fixes a logic error which meant that we didn't iterate over all logical
    switches when associating a FIP to an OVN loadbalancer. The symptom was
    that the FIP would show in neutron, but would not exist in OVN.
    
    Closes-Bug: #2068644
    Change-Id: I6d1979dfb4d6f455ca419e64248087047fbf73d7
    Co-Authored-By: Brian Haley <haleyb.dev@xxxxxxxxx>


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2068644

Title:
  Issue associating floating IP with OVN load balancer

Status in neutron:
  Fix Released

Bug description:
  Version: yoga

  I'm seeing this failure when trying to associate a floating IP to a
  OVN based loadbalancer:

      Maintenance task: Failed to fix resource 990f1d44-2401-49ba-b8c5-aedf7fb0c1ec (type: floatingips): TypeError: 'NoneType' object is not iterable
      2024-06-06 15:25:22.565 40 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance Traceback (most recent call last):
      2024-06-06 15:25:22.565 40 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance   File "/var/lib/kolla/venv/lib/python3.9/site-packages/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py", line 400, in check_for_inconsistencies
      2024-06-06 15:25:22.565 40 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance     self._fix_create_update(admin_context, row)
      2024-06-06 15:25:22.565 40 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance   File "/var/lib/kolla/venv/lib/python3.9/site-packages/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py", line 239, in _fix_create_update
      2024-06-06 15:25:22.565 40 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance     res_map['ovn_create'](context, n_obj)
      2024-06-06 15:25:22.565 40 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance   File "/var/lib/kolla/venv/lib/python3.9/site-packages/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py", line 467, in _create_floatingip_and_pf
      2024-06-06 15:25:22.565 40 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance     self._ovn_client.create_floatingip(context, floatingip)
      2024-06-06 15:25:22.565 40 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance   File "/var/lib/kolla/venv/lib/python3.9/site-packages/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py", line 1201, in create_floatingip
      2024-06-06 15:25:22.565 40 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance     LOG.error('Unable to create floating ip in gateway '
      2024-06-06 15:25:22.565 40 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance   File "/var/lib/kolla/venv/lib/python3.9/site-packages/oslo_utils/excutils.py", line 227, in __exit__
      2024-06-06 15:25:22.565 40 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance     self.force_reraise()
      2024-06-06 15:25:22.565 40 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance   File "/var/lib/kolla/venv/lib/python3.9/site-packages/oslo_utils/excutils.py", line 200, in force_reraise
      2024-06-06 15:25:22.565 40 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance     raise self.value
      2024-06-06 15:25:22.565 40 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance   File "/var/lib/kolla/venv/lib/python3.9/site-packages/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py", line 1197, in create_floatingip
      2024-06-06 15:25:22.565 40 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance     self._create_or_update_floatingip(floatingip, txn=txn)
      2024-06-06 15:25:22.565 40 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance   File "/var/lib/kolla/venv/lib/python3.9/site-packages/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py", line 1007, in _create_or_update_floatingip
      2024-06-06 15:25:22.565 40 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance     commands.extend(
      2024-06-06 15:25:22.565 40 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance TypeError: 'NoneType' object is not iterable
      2024-06-06 15:25:22.565 40 ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance 

  Unsure if that is masking another issue, but seems like even in master
  _handle_lb_fip_cmds can return None e.g:

  https://github.com/openstack/neutron/blob/11027e3e1ef9a58d5b2faa575a3764bd33cd2a08/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py#L975

  Unsure of the consqeuences of returning an empty list instead. Would
  that allow floating IP association to succeed?

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2068644/+subscriptions