yahoo-eng-team team mailing list archive

[OpenStack Infra <2081859@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/nova/+/849328
Committed: https://opendev.org/openstack/nova/commit/8c1a47c9cf6e1001fbefd6ff3b76314e39c81d71
Submitter: "Zuul (22348)"
Branch:    master

commit 8c1a47c9cf6e1001fbefd6ff3b76314e39c81d71
Author: Gorka Eguileor <geguileo@xxxxxxxxxx>
Date:   Thu Jul 7 16:22:42 2022 +0200

    Support os-brick specific lock_path
    
    Note: Initially this patch was related to new feature, but now it has
    become a bug since os-brick's `setup` method is not being called and it
    can create problems if os-brick changes.
    
    As a new feature, os-brick now supports setting the location of file
    locks in a different location from the locks of the service.
    
    The functionality is intended for HCI deployments and hosts that are
    running Cinder and Glance using Cinder backend.  In those scenarios the
    service can use a service specific location for its file locks while
    only sharing the location of os-brick with the other services.
    
    To leverage this functionality the new os-brick code is needed and
    method ``os_brick.setup`` needs to be called once the service
    configuration options have been loaded.
    
    The default value of the os-brick ``lock_path`` is the one set in
    ``oslo_concurrency``.
    
    This patch adds support for this new feature in a non backward
    compatible way, so it requires an os-brick version bump in the
    requirements.
    
    The patch also ensures that ``tox -egenconfig`` includes the os-brick
    configuration options when generating the sample config.
    
    Closes-Bug: #2081859
    Change-Id: I1b81eb65bd145869e8cf6f3aabc6ade58f832a19


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/2081859

Title:
  Nova not initializing os-brick

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  In the Zed release os-brick started needing to be initialized by
  calling a `setup` method before the library could be used.

  At that time there was only 1 feature that depended on it and it was
  possible to introduce a failsafe for that instance so things wouldn't
  break.

  In the Antelope release that failsafe should have been removed from
  os-brick and all projects should have been calling the `setup` method.

  Currently nova is not initializing os-brick, so if os-brick removes
  the failsafe the behavior in os-brick locks will break backward
  compatibility.

  Related os-brick patch: https://review.opendev.org/c/openstack/os-
  brick/+/849324

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/2081859/+subscriptions