yahoo-eng-team team mailing list archive

[OpenStack Infra <2085946@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/933752
Committed: https://opendev.org/openstack/neutron/commit/a298a37fe7ee41d25db02fdde36e134b01ef5d9a
Submitter: "Zuul (22348)"
Branch:    master

commit a298a37fe7ee41d25db02fdde36e134b01ef5d9a
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Wed Oct 30 00:58:16 2024 +0000

    [OVN] Fix the revision number retrieval method
    
    The "ovn_revision_numbers" table has a unique constraint that is a
    combination of the "resource_uuid" and the "resource_type". There is
    a case where the resource_uuid can be the same for two registers.
    A router interface will create a single Neutron DB register ("ports")
    but it will require two OVN DB registers ("Logical_Switch_Port" and
    "Logical_Router_Ports"). In this case is needed to define the
    "resource_type" when retrieving the revision number.
    
    The exception "RevisionNumberNotDefined" will be thrown if only the
    "resource_uuid" is provided in the related case.
    
    Closes-Bug: #2085946
    Change-Id: I12079de78773f7409503392d4791848aea90cb7b


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2085946

Title:
  [OVN] Revision number registers must be filtered by resource ID and
  type

Status in neutron:
  Fix Released

Bug description:
  The OVN revision numbers have a multicolumn index: (resource_uuid,
  resource_type) [1]. In particular because of the Neutron ports that
  belong to a router. A router interface is a single Neutron register
  ("ports"). But in OVN two registers are created:
  "Logical_Switch_Ports" and "Logical_Router_Ports".

  When retrieving a register "ovn_revision_numbers" from the Neutron
  database, it is needed to provide both the resource_uuid and the
  resource_type [2].

  [1]https://github.com/openstack/neutron/blob/febdfb5d8b1cf261c13b40e330d91a5bcb6c7642/neutron/db/models/ovn.py#L41-L46
  [2]https://github.com/openstack/neutron/blob/febdfb5d8b1cf261c13b40e330d91a5bcb6c7642/neutron/db/ovn_revision_numbers_db.py#L159-L167

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2085946/+subscriptions