yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #94885
[Bug 2081732] Re: oslo_utils.secretutils.constant_time_compare is redundant
Reviewed: https://review.opendev.org/c/openstack/keystonemiddleware/+/931148
Committed: https://opendev.org/openstack/keystonemiddleware/commit/cdc89b65f98bc2b4bf02f702c7ea24a5eee4fec7
Submitter: "Zuul (22348)"
Branch: master
commit cdc89b65f98bc2b4bf02f702c7ea24a5eee4fec7
Author: Takashi Kajinami <kajinamit@xxxxxxxxxxxxxxx>
Date: Wed Oct 2 18:30:39 2024 +0900
Replace deprecated constant_time_compare
The method is being deprecated now[1].
[1] https://review.opendev.org/c/openstack/oslo.utils/+/930198
Closes-Bug: #2081732
Change-Id: Ia46b03588cfa659edcae626f0bf8d65520354059
** Changed in: keystonemiddleware
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/2081732
Title:
oslo_utils.secretutils.constant_time_compare is redundant
Status in Ceilometer:
New
Status in keystonemiddleware:
Fix Released
Status in OpenStack Compute (nova):
In Progress
Status in octavia:
Fix Released
Status in oslo.utils:
Fix Released
Status in osprofiler:
In Progress
Bug description:
The constant_time_compare function is equivalent to
hmac.compare_digest in Python 3, because the constant_time_compare
function has been available since Python 3.3 .
[1] https://docs.python.org/3/library/hmac.html#hmac.compare_digest
We can get rid of the redundant wrapper and use the built-in
implementation instead.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ceilometer/+bug/2081732/+subscriptions