yahoo-eng-team team mailing list archive

[OpenStack Infra <2081732@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/nova/+/931146
Committed: https://opendev.org/openstack/nova/commit/aa943fcb29c455cd6b9918479a99d660e67a7a0e
Submitter: "Zuul (22348)"
Branch:    master

commit aa943fcb29c455cd6b9918479a99d660e67a7a0e
Author: Takashi Kajinami <kajinamit@xxxxxxxxxxxxxxx>
Date:   Wed Oct 2 18:26:30 2024 +0900

    Replace deprecated constant_time_compare
    
    The method is being deprecated now[1].
    
    [1] https://review.opendev.org/c/openstack/oslo.utils/+/930198
    
    Closes-Bug: #2081732
    Change-Id: Iae77e4fa7f6f078edc2ed3f85d98a7274757bb13


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/2081732

Title:
  oslo_utils.secretutils.constant_time_compare is redundant

Status in Ceilometer:
  Fix Released
Status in keystonemiddleware:
  Fix Released
Status in OpenStack Compute (nova):
  Fix Released
Status in octavia:
  Fix Released
Status in oslo.utils:
  Fix Released
Status in osprofiler:
  Fix Released

Bug description:
  The constant_time_compare function is equivalent to
  hmac.compare_digest in Python 3, because the constant_time_compare
  function has been available since Python 3.3 .

  [1] https://docs.python.org/3/library/hmac.html#hmac.compare_digest

  We can get rid of the redundant wrapper and use the built-in
  implementation instead.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ceilometer/+bug/2081732/+subscriptions