yahoo-eng-team team mailing list archive

[OpenStack Infra <2091021@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/937097
Committed: https://opendev.org/openstack/neutron/commit/813e743f0665b30082e3f6789850019dc35bcad7
Submitter: "Zuul (22348)"
Branch:    master

commit 813e743f0665b30082e3f6789850019dc35bcad7
Author: Slawek Kaplonski <skaplons@xxxxxxxxxx>
Date:   Thu Dec 5 10:02:22 2024 +0100

    [Fullstack] Don't assert no connectivity after host is stopped
    
    In the fullstack L3 HA tests, after fake host with router was killed
    or disconnected (so wasn't stopped gracefully) there was assertion that
    connectivity using Floating IP is broken for short period of time.
    This could lead to the race between test and keepalived which is doing
    failover. If keepalived was fast enough, test could fail at this
    assertion as failover would already happen and Floating IP would be
    working fine again.
    
    This patch removes that assertion of no connectity as this can't be
    really controlled by the test and may lead to random failures. It's also
    not the most important thing in those tests - we should make sure that
    connectivity is working fine after host is crashed thanks to the
    failover which should happen and that is tested in the same tests.
    
    Closes-bug: #2091021
    Change-Id: Ib00c9823e3600bb2c234cbc90cac81723b4eec11


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2091021

Title:
  Fullstack ha failover tests from
  neutron.tests.fullstack.test_l3_agent.TestHAL3Agent failing due to
  "destination ip 42.0.0.15 is replying to ping from namespace
  test-3dc5c664-ddba-4c2e-a9a9-48bbda478506, but it shouldn't"

Status in neutron:
  Fix Released

Bug description:
  Traceback:

  ft1.10: neutron.tests.fullstack.test_l3_agent.TestHAL3Agent.test_ha_router_failover_host_failuretesttools.testresult.real._StringException: Traceback (most recent call last):
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 178, in func
      return f(self, *args, **kwargs)
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/fullstack/test_l3_agent.py", line 565, in test_ha_router_failover_host_failure
      self._test_ha_router_failover('kill')
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/fullstack/test_l3_agent.py", line 522, in _test_ha_router_failover
      vm.assert_no_ping(external.ip)
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/common/machine_fixtures.py", line 86, in assert_no_ping
      net_helpers.assert_no_ping(self.namespace, dst_ip)
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/common/net_helpers.py", line 168, in assert_no_ping
      tools.fail("destination ip %(destination)s is replying to ping from "
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/tools.py", line 167, in fail
      raise unittest.TestCase.failureException(msg)
  AssertionError: destination ip 42.0.0.15 is replying to ping from namespace test-3dc5c664-ddba-4c2e-a9a9-48bbda478506, but it shouldn't

  Failure example:
  https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_e5c/periodic/opendev.org/openstack/neutron/master/neutron-
  fullstack/e5cb4b0/testr_results.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2091021/+subscriptions