yahoo-eng-team team mailing list archive

[OpenStack Infra <2091071@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/936988
Committed: https://opendev.org/openstack/neutron/commit/ce6e2d87c52a11ec76a0f6fb7deb25a3dc26cf86
Submitter: "Zuul (22348)"
Branch:    master

commit ce6e2d87c52a11ec76a0f6fb7deb25a3dc26cf86
Author: Kien Nguyen Tuan <kiennt2609@xxxxxxxxx>
Date:   Wed Dec 4 11:10:47 2024 +0700

    Use the correct input for OVN agent deletion
    
    The key [1] is a list which is unhashable, therefore,
    it can not be passed as dict key [2]. It causes
    TypeError: unhashable type: 'list' exception.
    
    [1] https://github.com/openstack/neutron/blob/24e70ea166b517df78ca720b279e2520720de1e7/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py#L332
    [2] https://github.com/openstack/neutron/blob/24e70ea166b517df78ca720b279e2520720de1e7/neutron/plugins/ml2/drivers/ovn/agent/neutron_agent.py#L281
    
    Closes-bug: #2091071
    Change-Id: I064d9b3e6cb72562a16030e1b31de45ddc8f487c


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2091071

Title:
  ovn-agent: exception when deleing agent

Status in neutron:
  Fix Released

Bug description:
  Call neutron API to delete ovn agent, it returns 204 but the agent
  isn't deleted. Check neutron-server.log find out there is an exception
  when deleting agent:

  ```
  2024-12-04 09:21:15.303 838 ERROR ovsdbapp.event [-] Unexpected exception in notify_loop: TypeError: unhashable type: 'list'
  2024-12-04 09:21:15.303 838 ERROR ovsdbapp.event Traceback (most recent call last):
  2024-12-04 09:21:15.303 838 ERROR ovsdbapp.event   File "/var/lib/kolla/venv/lib/python3.10/site-packages/ovsdbapp/event.py", line 177, in notify_loop
  2024-12-04 09:21:15.303 838 ERROR ovsdbapp.event     match.run(event, row, updates)
  2024-12-04 09:21:15.303 838 ERROR ovsdbapp.event   File "/var/lib/kolla/venv/lib/python3.10/site-packages/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py", line 330, in run
  2024-12-04 09:21:15.303 838 ERROR ovsdbapp.event     n_agent.AgentCache().delete([row.external_ids['delete_agent']])
  2024-12-04 09:21:15.303 838 ERROR ovsdbapp.event   File "/var/lib/kolla/venv/lib/python3.10/site-packages/neutron/plugins/ml2/drivers/ovn/agent/neutron_agent.py", line 282, in delete
  2024-12-04 09:21:15.303 838 ERROR ovsdbapp.event     del self.agents[agent_id]
  2024-12-04 09:21:15.303 838 ERROR ovsdbapp.event TypeError: unhashable type: 'list'
  2024-12-04 09:21:15.303 838 ERROR ovsdbapp.event
  2024-12-04 09:21:15.303 799 ERROR ovsdbapp.event [-] Unexpected exception in notify_loop: TypeError: unhashable type: 'list'
  2024-12-04 09:21:15.303 799 ERROR ovsdbapp.event Traceback (most recent call last):
  2024-12-04 09:21:15.303 799 ERROR ovsdbapp.event   File "/var/lib/kolla/venv/lib/python3.10/site-packages/ovsdbapp/event.py", line 177, in notify_loop
  2024-12-04 09:21:15.303 799 ERROR ovsdbapp.event     match.run(event, row, updates)
  2024-12-04 09:21:15.303 799 ERROR ovsdbapp.event   File "/var/lib/kolla/venv/lib/python3.10/site-packages/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py", line 330, in run
  2024-12-04 09:21:15.303 799 ERROR ovsdbapp.event     n_agent.AgentCache().delete([row.external_ids['delete_agent']])
  2024-12-04 09:21:15.303 799 ERROR ovsdbapp.event   File "/var/lib/kolla/venv/lib/python3.10/site-packages/neutron/plugins/ml2/drivers/ovn/agent/neutron_agent.py", line 282, in delete
  2024-12-04 09:21:15.303 799 ERROR ovsdbapp.event     del self.agents[agent_id]
  2024-12-04 09:21:15.303 799 ERROR ovsdbapp.event TypeError: unhashable type: 'list'
  ```

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2091071/+subscriptions