← Back to team overview

yahoo-eng-team team mailing list archive

  1. yahoo-eng-team team
  2. Mailing list archive
  3. Message #95118

[Bug 2092722] [NEW] with pyroute2 master dvr functional tests failing as pyroute.NetNS not honoring flags

  Thread Previous • Date Previous • • Thread Next 
Public bug reported:

The tests fails as:-
test_floating_ip_not_deployed_on_dvr_no_external_agent
ft1.66: neutron.tests.functional.agent.l3.extensions.qos.test_fip_qos_extension.TestL3AgentFipQosExtensionDVR.test_floating_ip_not_deployed_on_dvr_no_external_agenttesttools.testresult.real._StringException: Traceback (most recent call last):
  File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 178, in func
    return f(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 178, in func
    return f(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/agent/l3/test_dvr_router.py", line 1345, in test_floating_ip_not_deployed_on_dvr_no_external_agent
    self.assertFalse(self._namespace_exists(fip_ns))
  File "/usr/lib/python3.12/unittest/case.py", line 721, in assertFalse
    raise self.failureException(msg)
AssertionError: True is not false

test_dvr_lifecycle_ha_with_snat_with_fips_with_cent_fips_no_gw
ft2.45: neutron.tests.functional.agent.l3.extensions.test_gateway_ip_qos_extension.TestRouterGatewayIPQosAgentExtensionDVR.test_dvr_lifecycle_ha_with_snat_with_fips_with_cent_fips_no_gwtesttools.testresult.real._StringException: Traceback (most recent call last):
  File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 178, in func
    return f(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 178, in func
    return f(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/agent/l3/test_dvr_router.py", line 223, in test_dvr_lifecycle_ha_with_snat_with_fips_with_cent_fips_no_gw
    self._dvr_router_lifecycle(enable_ha=True, enable_snat=True,
  File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/agent/l3/test_dvr_router.py", line 654, in _dvr_router_lifecycle
    self._assert_router_does_not_exist(router)
  File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/agent/l3/framework.py", line 526, in _assert_router_does_not_exist
    self.assertFalse(self._namespace_exists(router.ns_name))
  File "/usr/lib/python3.12/unittest/case.py", line 721, in assertFalse
    raise self.failureException(msg)
AssertionError: True is not false


test_dvr_unused_snat_ns_deleted_when_agent_restarts_after_move
ft2.40: neutron.tests.functional.agent.l3.extensions.test_gateway_ip_qos_extension.TestRouterGatewayIPQosAgentExtensionDVR.test_dvr_unused_snat_ns_deleted_when_agent_restarts_after_movetesttools.testresult.real._StringException: Traceback (most recent call last):
  File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 178, in func
    return f(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 178, in func
    return f(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/agent/l3/test_dvr_router.py", line 522, in test_dvr_unused_snat_ns_deleted_when_agent_restarts_after_move
    self._assert_snat_namespace_does_not_exist(restarted_router)
  File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/agent/l3/test_dvr_router.py", line 764, in _assert_snat_namespace_does_not_exist
    self.assertFalse(self._namespace_exists(namespace))
  File "/usr/lib/python3.12/unittest/case.py", line 721, in assertFalse
    raise self.failureException(msg)
AssertionError: True is not false


Example failure:- https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_466/periodic/opendev.org/openstack/neutron/master/neutron-functional-with-pyroute2-master/4662eac/testr_results.html

Builds:- https://zuul.openstack.org/builds?job_name=neutron-functional-
with-pyroute2-master&project=openstack/neutron

With upper-constraint version 0.7.12 and latest release 0.8.1 it works
fine, with pyroute2 master these tests fails.

pyroute2 master is not honoring flags=0 which we use (to not create a
network namespace)
https://github.com/openstack/neutron/blob/1da3fbf4f0e1ae4bdbb48b50da151ef06c1d12fe/neutron/privileged/agent/linux/ip_lib.py#L148-L149

** Affects: neutron
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2092722

Title:
   with pyroute2 master dvr functional tests failing as pyroute.NetNS
  not honoring flags

Status in neutron:
  New

Bug description:
  The tests fails as:-
  test_floating_ip_not_deployed_on_dvr_no_external_agent
  ft1.66: neutron.tests.functional.agent.l3.extensions.qos.test_fip_qos_extension.TestL3AgentFipQosExtensionDVR.test_floating_ip_not_deployed_on_dvr_no_external_agenttesttools.testresult.real._StringException: Traceback (most recent call last):
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 178, in func
      return f(self, *args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 178, in func
      return f(self, *args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/agent/l3/test_dvr_router.py", line 1345, in test_floating_ip_not_deployed_on_dvr_no_external_agent
      self.assertFalse(self._namespace_exists(fip_ns))
    File "/usr/lib/python3.12/unittest/case.py", line 721, in assertFalse
      raise self.failureException(msg)
  AssertionError: True is not false

  test_dvr_lifecycle_ha_with_snat_with_fips_with_cent_fips_no_gw
  ft2.45: neutron.tests.functional.agent.l3.extensions.test_gateway_ip_qos_extension.TestRouterGatewayIPQosAgentExtensionDVR.test_dvr_lifecycle_ha_with_snat_with_fips_with_cent_fips_no_gwtesttools.testresult.real._StringException: Traceback (most recent call last):
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 178, in func
      return f(self, *args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 178, in func
      return f(self, *args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/agent/l3/test_dvr_router.py", line 223, in test_dvr_lifecycle_ha_with_snat_with_fips_with_cent_fips_no_gw
      self._dvr_router_lifecycle(enable_ha=True, enable_snat=True,
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/agent/l3/test_dvr_router.py", line 654, in _dvr_router_lifecycle
      self._assert_router_does_not_exist(router)
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/agent/l3/framework.py", line 526, in _assert_router_does_not_exist
      self.assertFalse(self._namespace_exists(router.ns_name))
    File "/usr/lib/python3.12/unittest/case.py", line 721, in assertFalse
      raise self.failureException(msg)
  AssertionError: True is not false

  
  test_dvr_unused_snat_ns_deleted_when_agent_restarts_after_move
  ft2.40: neutron.tests.functional.agent.l3.extensions.test_gateway_ip_qos_extension.TestRouterGatewayIPQosAgentExtensionDVR.test_dvr_unused_snat_ns_deleted_when_agent_restarts_after_movetesttools.testresult.real._StringException: Traceback (most recent call last):
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 178, in func
      return f(self, *args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 178, in func
      return f(self, *args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/agent/l3/test_dvr_router.py", line 522, in test_dvr_unused_snat_ns_deleted_when_agent_restarts_after_move
      self._assert_snat_namespace_does_not_exist(restarted_router)
    File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/agent/l3/test_dvr_router.py", line 764, in _assert_snat_namespace_does_not_exist
      self.assertFalse(self._namespace_exists(namespace))
    File "/usr/lib/python3.12/unittest/case.py", line 721, in assertFalse
      raise self.failureException(msg)
  AssertionError: True is not false

  
  Example failure:- https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_466/periodic/opendev.org/openstack/neutron/master/neutron-functional-with-pyroute2-master/4662eac/testr_results.html

  Builds:- https://zuul.openstack.org/builds?job_name=neutron-
  functional-with-pyroute2-master&project=openstack/neutron

  With upper-constraint version 0.7.12 and latest release 0.8.1 it works
  fine, with pyroute2 master these tests fails.

  pyroute2 master is not honoring flags=0 which we use (to not create a
  network namespace)
  https://github.com/openstack/neutron/blob/1da3fbf4f0e1ae4bdbb48b50da151ef06c1d12fe/neutron/privileged/agent/linux/ip_lib.py#L148-L149

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2092722/+subscriptions
  Thread Previous • Date Previous • • Thread Next