← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 2103408] Re: Duplicated table lookup in extending port resource request

 

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/944650
Committed: https://opendev.org/openstack/neutron/commit/2fd51371ec95a712300707623f77ced6969d54fc
Submitter: "Zuul (22348)"
Branch:    master

commit 2fd51371ec95a712300707623f77ced6969d54fc
Author: jimin3-shin <jimin3.shin@xxxxxxxxxxx>
Date:   Thu Mar 13 14:50:25 2025 +0900

    Duplicated table lookup in extending port resource request
    
    There are duplicated table lookup in the _get_min_bw_request_group,
    _get_min_pps_request_group method. If there is no minimum bandwidth
    rule or minimum packet rate rule, empty list ([]) can be passed to
    the method. Since empty list ([]) is False, the method lookup the
    table again, which is unnecessary. This occurs longer time taking in
    port list api.
    
    Closes-Bug: #2103408
    Change-Id: I21d7b51094bd91ed62e8ffed798aae0e29b6ca61


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2103408

Title:
  Duplicated table lookup in extending port resource request

Status in neutron:
  Fix Released

Bug description:
  There are duplicated table lookup in the _get_min_bw_request_group, _get_min_pps_request_group method.
  If there is no minimum bandwidth rule or minimum packet rate rule, empty list ([]) can be passed to the method.
  Since empty list ([]) is False, the method lookup the table again, which is unnecessary.
  This occurs longer time taking in port list api.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2103408/+subscriptions



References