← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 2110018] [NEW] [OVN] FIP QoS and router QoS have the same priority

 

Public bug reported:

The default QoS priority for an OVN QoS rule is
"OVN_QOS_DEFAULT_RULE_PRIORITY = 2002" [1].

A port connected to a router can have up to 3 QoS rules applied:
* The port QoS
* The router QoS
* The FIP QoS (when a FIP is assigned).

The port QoS will always match first because of the egress/ingress port
and will have precedence over the other 2.

The problem is how to handle the priority of the router QoS and FIP QoS.
Both rules are matching the egress/ingress gateway LRP (the FIP is also
matching the IP address and the CR port, if present). According to [2],
"if two QoS rules with the same priority both match, then the one
actually applied to a packet is undefined". Because of that, we need to
increase the priority of the FIP rules that will superseed the router
QoS one.

[1]https://github.com/openstack/neutron/blob/aa4ab837a0390b1c1c3039fe0b196361178f5749/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/extensions/qos.py#L35
[2]https://www.ovn.org/support/dist-docs/ovn-nb.5.html

** Affects: neutron
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2110018

Title:
  [OVN] FIP QoS and router QoS have the same priority

Status in neutron:
  New

Bug description:
  The default QoS priority for an OVN QoS rule is
  "OVN_QOS_DEFAULT_RULE_PRIORITY = 2002" [1].

  A port connected to a router can have up to 3 QoS rules applied:
  * The port QoS
  * The router QoS
  * The FIP QoS (when a FIP is assigned).

  The port QoS will always match first because of the egress/ingress
  port and will have precedence over the other 2.

  The problem is how to handle the priority of the router QoS and FIP
  QoS. Both rules are matching the egress/ingress gateway LRP (the FIP
  is also matching the IP address and the CR port, if present).
  According to [2], "if two QoS rules with the same priority both match,
  then the one actually applied to a packet is undefined". Because of
  that, we need to increase the priority of the FIP rules that will
  superseed the router QoS one.

  [1]https://github.com/openstack/neutron/blob/aa4ab837a0390b1c1c3039fe0b196361178f5749/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/extensions/qos.py#L35
  [2]https://www.ovn.org/support/dist-docs/ovn-nb.5.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2110018/+subscriptions



Follow ups