yahoo-eng-team team mailing list archive

[OpenStack Infra <2081243@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/horizon/+/929984
Committed: https://opendev.org/openstack/horizon/commit/58858767663978c84273363ae85b62dccacca82d
Submitter: "Zuul (22348)"
Branch:    master

commit 58858767663978c84273363ae85b62dccacca82d
Author: chung00-lee <chung00.lee@xxxxxxxxxxx>
Date:   Fri Sep 20 11:12:53 2024 +0900

    Fix filter in '/keystone/svc-catalog' api
    
    Changed to use list append instead of list remove in for loop
    
    Closes-Bug: #2081243
    Change-Id: I4259aa4fd940e370261117e27c3254278f5363c1


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/2081243

Title:
  The get function in the keystone/svc-catalog API operates differently
  than intended.

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  There is a problem with list remove in for loop.(
  https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/api/rest/keystone.py#L540
  )

  sample catalog : 
  [
      {
          'endpoints': [
                  {'url': 'http://cool_url/image',
                   'interface': 'admin',
                   'region': 'RegionOne',
                   'region_id': 'RegionOne',
                   'id': 'test'},
                  {'url': 'http://cool_url/image',
                   'interface': 'internal',
                   'region': 'RegionOne',
                   'region_id': 'RegionOne',
                   'id': 'test'},
                  {'url': 'http://cool_url/image',
                   'interface': 'public',
                   'region': 'RegionOne',
                   'region_id': 'RegionOne',
                   'id': 'test'}
          ],
          'type': 'image',
          'id': 'id',
          'name': 'glance'
      }
  ]

  
  Expected :
  [
      {
          'endpoints': [
                  {'url': 'http://cool_url/image',
                   'interface': 'public',
                   'region': 'RegionOne',
                   'region_id': 'RegionOne',
                   'id': 'test'}
          ],
          'type': 'image',
          'id': 'id',
          'name': 'glance'
      }
  ]

  
  Actual :
  [
      {
          'endpoints': [
                  {'url': 'http://cool_url/image',
                   'interface': 'internal',
                   'region': 'RegionOne',
                   'region_id': 'RegionOne',
                   'id': 'test'},
                  {'url': 'http://cool_url/image',
                   'interface': 'public',
                   'region': 'RegionOne',
                   'region_id': 'RegionOne',
                   'id': 'test'}
          ],
          'type': 'image',
          'id': 'id',
          'name': 'glance'
      }
  ]

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/2081243/+subscriptions