yahoo-eng-team team mailing list archive

[Andriy Kurilin <2111506@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The commit f044c4b0a30da4b4b5e3df1b7888811efddce447 (change-id:
Ifdad18e805953957bfaa1b42908dfbbe8976dbcb) changed the way of handling
errors of all API calls.

I do not know whether it was done intentionally or not, but it resulted
in side effect.

Previous behaviour:
1) user wants to launch a VM and he/she/it opens `Launch instance` window, which is handled by wizard widget
2) user fills all the forms and clicks Launch button
3) nova API returns an error immediately
4) horizon nova.createServer method adds the error-popup to top right corner of browser with 'Unable to create the server' message
5) wizard widget DOES not close up 'launch instance' window
6) wizard widget puts the original error from the Nova to the top of the window, so user can see it and if it relates to input data, he/she/it can modify request/input and resubmit it.

The new behaviour does not touch 1-4 steps, they are the same:)
5) wizard widget receives 'processed-error', so it closes the window and
   prints 'success' message as a popup to top right corner

The new behaviour does not allow the user to fix input, a success popup is displayed as soon as request is submitted and error popup appears as soon as nova returns an error.
Also, the original error from Nova API is not displayed anywhere and the
user does not have much info to understand what went wrong.

Since the way of handling exceptions changed for all api calls, I assume
that the 'root-cause' commit could affect other user-flows

An example of a fix applied locally to bypass an issue:
https://review.opendev.org/c/openstack/horizon/+/871285/1/openstack_dashboard/static/app/core/openstack-
service-api/nova.service.js

** Affects: horizon
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/2111506

Title:
  Horizon does not propagate nova errors anymore

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  The commit f044c4b0a30da4b4b5e3df1b7888811efddce447 (change-id:
  Ifdad18e805953957bfaa1b42908dfbbe8976dbcb) changed the way of handling
  errors of all API calls.

  I do not know whether it was done intentionally or not, but it
  resulted in side effect.

  Previous behaviour:
  1) user wants to launch a VM and he/she/it opens `Launch instance` window, which is handled by wizard widget
  2) user fills all the forms and clicks Launch button
  3) nova API returns an error immediately
  4) horizon nova.createServer method adds the error-popup to top right corner of browser with 'Unable to create the server' message
  5) wizard widget DOES not close up 'launch instance' window
  6) wizard widget puts the original error from the Nova to the top of the window, so user can see it and if it relates to input data, he/she/it can modify request/input and resubmit it.

  The new behaviour does not touch 1-4 steps, they are the same:)
  5) wizard widget receives 'processed-error', so it closes the window and
     prints 'success' message as a popup to top right corner

  The new behaviour does not allow the user to fix input, a success popup is displayed as soon as request is submitted and error popup appears as soon as nova returns an error.
  Also, the original error from Nova API is not displayed anywhere and the
  user does not have much info to understand what went wrong.

  Since the way of handling exceptions changed for all api calls, I
  assume that the 'root-cause' commit could affect other user-flows

  An example of a fix applied locally to bypass an issue:
  https://review.opendev.org/c/openstack/horizon/+/871285/1/openstack_dashboard/static/app/core/openstack-
  service-api/nova.service.js

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/2111506/+subscriptions