yahoo-eng-team team mailing list archive

[OpenStack Infra <2103412@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/944756
Committed: https://opendev.org/openstack/neutron/commit/19774fde2f6527782eb898197eaf571de6375951
Submitter: "Zuul (22348)"
Branch:    master

commit 19774fde2f6527782eb898197eaf571de6375951
Author: jimin3-shin <jimin3.shin@xxxxxxxxxxx>
Date:   Mon Mar 17 11:44:32 2025 +0900

    Extend port resource request only when using qos minimum rules
    
    In the method [1], if there is no minimum bandwidth rule and
    minimum packet rate rule in the port's qos policy,
    port['resource_request'] is set to None in the end, which means
    no furthermore resource_request extension is required in those cases.
    
    This change checks first if there are minimum bandwith rules and
    minimum packet rate rules in the policy. If there is no minimum rule,
    set port_res['resource_request'] to None, and then continue the
    for loop.
    
    This change adds a test checking resource_request extension is not
    done and ports' resource_request is set to None in this case.
    
    There is change in existing test. This change fixes test which is
    affected by the modified method[1]. This change adds new member
    variables network_id and ports_res, and uses them instead of defining
    new ones in the other tests.
    
    [1] https://github.com/openstack/neutron/blob/master/neutron/services/qo
    s/qos_plugin.py#L276
    
    Closes-Bug: #2103412
    Change-Id: I4d84cbf21be5e065a6ff57ba87352e2b602862b5


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2103412

Title:
  Extend port resource request when not using qos minimum rules

Status in neutron:
  Fix Released

Bug description:
  In the method [1], if there is no minimum bandwidth rule and minimum packet rate rule in the port's qos policy, port['resource_request'] is set to None in the end.
  In the system not using minimum bandwidth rule and minimum packet rate rule, it doesn't have to make db calls, and this will reduce port retrieval time.
  Therefore, I suggest check presence of minimum rules first, and do resource_request extension.

  [1]https://github.com/openstack/neutron/blob/26739f7c769a48f71c8590bbc481e1a11d8e793f/neutron/services/qos/qos_plugin.py#L276

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2103412/+subscriptions