yahoo-eng-team team mailing list archive

[OpenStack Infra <2020552@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.opendev.org/c/openstack/neutron/+/946124
Committed: https://opendev.org/openstack/neutron/commit/1c93c84d1c16d9ede1950f9756b8bd04302fdc68
Submitter: "Zuul (22348)"
Branch:    master

commit 1c93c84d1c16d9ede1950f9756b8bd04302fdc68
Author: Maksim Kostrow <maks.kostrow@xxxxxxxxx>
Date:   Wed Apr 2 11:47:59 2025 +0300

    Correction of a typo in the 'sub_ports' field
    
    Problem: In the "_extend_port_trunk_details_bulk"
    method for the trunk plugin, the search of subports
    takes place using the key 'subports' instead 'sub_ports'.
    That cause the mac address field has never added to the subports.
    It also leads to consistency with the documented API:
    https://docs.openstack.org/api-ref/network/v2/index.html#show-trunk-details
    
    Closes-Bug: #2020552
    Change-Id: I113714a21692bfb6be9a21586de172a62191619f


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/2020552

Title:
  trunk_details missing sub port MAC addresses for LIST

Status in neutron:
  Fix Released

Bug description:
  When returning port details, trunk_details.sub_ports should contain:
  * segmentation_id
  * segmentation_type
  * port_id
  * mac_address

  This is the case when GETting a single port, but when listing ports
  mac_address is missing.

  In the following:
  * Parent port: a47df912-1cba-458c-9bb9-00cd3d71b9e6
  * Trunk: 70f314f8-5577-4b98-be9c-68bbe3791d7f
  * Sub port: d11793a9-8862-4378-a1fe-045f04dad841

  GET request:

  > curl -s -H "X-Auth-Token: $OS_TOKEN" "https://rhos-d.infra.prod.upshift.rdu2.redhat.com:13696/v2.0/ports/a47df912-1cba-458c-9bb9-00cd3d71b9e6"; | jq
  {
    "port": {
      ...
      "trunk_details": {
        "trunk_id": "70f314f8-5577-4b98-be9c-68bbe3791d7f",
        "sub_ports": [
          {
            "segmentation_id": 100,
            "segmentation_type": "vlan",
            "port_id": "d11793a9-8862-4378-a1fe-045f04dad841",
            "mac_address": "fa:16:3e:88:29:a0"
          }
        ]
      },
      ...
    }
  }

  LIST request returning the same port:

  > curl -s -H "X-Auth-Token: $OS_TOKEN" "https://rhos-d.infra.prod.upshift.rdu2.redhat.com:13696/v2.0/ports?id=a47df912-1cba-458c-9bb9-00cd3d71b9e6"; | jq
  {
    "ports": [
      {
        ...
        "trunk_details": {
          "trunk_id": "70f314f8-5577-4b98-be9c-68bbe3791d7f",
          "sub_ports": [
            {
              "segmentation_id": 100,
              "segmentation_type": "vlan",
              "port_id": "d11793a9-8862-4378-a1fe-045f04dad841"
            }
          ]
        },
        ...
      }
    }
  }

  Note that mac_address is missing for the LIST request.

  * Version: Little bit of guesswork going on here, but Nova reports a
  latest microversion of 2.79, which corresponds to Train.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/2020552/+subscriptions